-
Notifications
You must be signed in to change notification settings - Fork 183
FIX: Allow KNN with missing values #2822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
/intelci: run |
|
/azp run Nightly |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/intelci: run |
|
/azp run Nightly |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
scikit-learn/scikit-learn#25319 @david-cortes-intel . Can you detail the missing value use case with an example? As of now we support these metrics: https://github.com/uxlfoundation/scikit-learn-intelex/blob/main/sklearnex/neighbors/common.py#L221 which does not include |
It still fails this test: |
|
@david-cortes-intel then I think there is a bug in the metrics check. I think that should be the avenue taken to fix the issue. |
|
Just wanted to note that I know that its a bit convoluted and annoying on the neighbors side of things here, I just want to make sure that if we can solve it without a separate finite check, then we should do that. |
236d53e to
937b209
Compare
Switched it to use the metric checks instead. |
|
/intelci: run |
Description
KNN algorithms on sklearn support data with missing values, but sklearnex makes a check for 'all finite'. This PR makes it fall back to sklearn when receiving data that has missing values.
Disclaimer: I'm not 100% sure about whether oneDAL supports KNN with missing values or not.
Checklist:
Completeness and readability
Testing