Skip to content

FIX: Allow KNN with missing values #2822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
david-cortes-intel wants to merge 2 commits into
base: main
Choose a base branch
from
Open

FIX: Allow KNN with missing values #2822

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
937b209
better fix without validating data twice
david-cortes-intel Dec 4, 2025
a4f4014
fix
david-cortes-intel Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions sklearnex/neighbors/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@

from .._utils import PatchingConditionsChain
from ..base import oneDALEstimator
from ..utils._array_api import get_namespace
from ..utils.validation import check_feature_names


Expand Down Expand Up @@ -68,7 +67,13 @@ def _fit_validation(self, X, y=None):

if not isinstance(X, (KDTree, BallTree, _sklearn_NeighborsBase)):
self._fit_X = _check_array(
X, dtype=[np.float64, np.float32], accept_sparse=True
X,
dtype=[np.float64, np.float32],
accept_sparse=True,
force_all_finite=not (
isinstance(self.effective_metric_, str)
and self.effective_metric_.startswith("nan")
),
)
self.n_samples_fit_ = _num_samples(self._fit_X)
self.n_features_in_ = _num_features(self._fit_X)
Expand Down
Loading