Skip to content

8373097: Save command should create missing parent directories #28662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sormuras wants to merge 3 commits into
base: master
Choose a base branch
from
+17 −2
Open

8373097: Save command should create missing parent directories #28662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
12da6a5
8373097: Save command should create missing parent directories
sormuras Dec 4, 2025
55b2eed
Add file with parent directories to `/save` test
sormuras Dec 4, 2025
668701d
Clean up
sormuras Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/jdk.jshell/share/classes/jdk/internal/jshell/tool/JShellTool.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3362,7 +3362,19 @@ private boolean cmdSave(String rawargs) {
// error occurred, already reported
return false;
}
try (BufferedWriter writer = Files.newBufferedWriter(toPathResolvingUserHome(filename),
// Create missing parent directories before writing to target file
Path target;
try {
target = toPathResolvingUserHome(filename);
Path parent = target.getParent();
if (parent != null) {
Files.createDirectories(parent);
}
} catch (Exception e) {
errormsg("jshell.err.file.exception", "/save", filename, e);
return false;
}
try (BufferedWriter writer = Files.newBufferedWriter(target,
Charset.defaultCharset(),
CREATE, TRUNCATE_EXISTING, WRITE)) {
if (at.hasOption("-history")) {
Expand Down
5 changes: 4 additions & 1 deletion test/langtools/jdk/jshell/ToolBasicTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,6 +585,7 @@ public void testSave() throws IOException {
Compiler compiler = new Compiler();
Path path = compiler.getPath("testSave.repl");
{
Path pathWithDirectories = compiler.getPath("what/ever/testSave.repl");
List<String> list = Arrays.asList(
"int a;",
"class A { public String toString() { return \"A\"; } }"
Expand All @@ -593,9 +594,11 @@ public void testSave() throws IOException {
(a) -> assertVariable(a, "int", "a"),
(a) -> assertCommand(a, "()", null, null, null, "", ""),
(a) -> assertClass(a, "class A { public String toString() { return \"A\"; } }", "class", "A"),
(a) -> assertCommand(a, "/save " + path.toString(), "")
(a) -> assertCommand(a, "/save " + path.toString(), ""),
(a) -> assertCommand(a, "/save " + pathWithDirectories.toString(), "")
);
assertEquals(list, Files.readAllLines(path));
assertEquals(list, Files.readAllLines(pathWithDirectories));
}
{
List<String> output = new ArrayList<>();
Expand Down