8373097: Save command should create missing parent directories #28662
+17
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review this change enhancing the
/save <file>command in JShell to create missing parent directories.Prior to this change, when the argument of a
/savecommand starts with a list of directory names, of which at least one does not exist, the command fails with an exception reading:Any exception happening during the creation of missing parent directories (using
Files.createDirectoriesAPI) is caught and transformed into file-related error message.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28662/head:pull/28662$ git checkout pull/28662Update a local copy of the PR:
$ git checkout pull/28662$ git pull https://git.openjdk.org/jdk.git pull/28662/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28662View PR using the GUI difftool:
$ git pr show -t 28662Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28662.diff
Using Webrev
Link to Webrev Comment