Skip to content

Optimieze Siteplan transform #2073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
TruongQuangSB wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Optimieze Siteplan transform #2073

TruongQuangSB wants to merge 2 commits into from
+93 −52

Conversation

@TruongQuangSB
Copy link
Contributor

@TruongQuangSB TruongQuangSB commented Dec 11, 2025

No description provided.

@TruongQuangSB TruongQuangSB linked an issue Dec 11, 2025 that may be closed by this pull request
Optimizer Cache Memory And Application performance #1932
Open
TruongQuangSB
TruongQuangSB commented Dec 11, 2025
View reviewed changes
...se.set.application/src/org/eclipse/set/application/geometry/GeoKanteGeometryServiceImpl.java
private Coordinate getGeoNodeCoordinate(final GEO_Knoten node) {
final GeoKanteGeometrySessionData sessionData = getSessionData(node);
return sessionData.getGeoNodeCoordinates()
.computeIfAbsent(node, GeoKnotenExtensions::getCoordinate);
Copy link
Contributor Author

@TruongQuangSB TruongQuangSB Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

store coordinate of GEO_Knoten instead of find the coordinate each call

java/bundles/org.eclipse.set.basis/src/org/eclipse/set/basis/geometry/GEOKanteMetadata.java
this.length = length;
this.geometry = geometry;
this.geoKnoten = geoKnoten;
this.geoCRS = geoCRS;
Copy link
Contributor Author

@TruongQuangSB TruongQuangSB Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

storage CRS direct in GEOKanteMetaData instead of find by each call

...set.feature.siteplan/src/org/eclipse/set/feature/siteplan/transform/TrackTransformator.xtend
BigDecimal.valueOf(2), ToolboxConstants.ROUNDING_TO_PLACE,
RoundingMode.HALF_UP) ?: BigDecimal.ZERO, BigDecimal.ZERO,
ENUMWirkrichtung.ENUM_WIRKRICHTUNG_IN)
]
Copy link
Contributor Author

@TruongQuangSB TruongQuangSB Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

calculate Center coordinate only by exist error

TruongQuangSB
TruongQuangSB commented Dec 11, 2025
View reviewed changes
...ipse.set.ppmodel.extensions/src/org/eclipse/set/ppmodel/extensions/GeoKnotenExtensions.xtend
) {
return knoten.container.GEOPunkt.filter [
IDGEOKnoten !== null && IDGEOKnoten?.wert == knoten.identitaet.wert
].toList
Copy link
Contributor Author

@TruongQuangSB TruongQuangSB Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need transform to list each call

@TruongQuangSB TruongQuangSB mentioned this pull request Dec 11, 2025
Open
@github-actions
Copy link

github-actions bot commented Dec 11, 2025

Test Results

130 tests  ±0   130 ✅ ±0   21s ⏱️ ±0s
 30 suites ±0     0 💤 ±0 
 30 files   ±0     0 ❌ ±0 

Results for commit 19a3318. ± Comparison against base commit 5889295.

This pull request removes 9 and adds 9 tests. Note that renamed tests count towards both. 
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[1] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@68868328
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[2] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@2da3b078
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[3] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@3078cac
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[4] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@5f2bd6d9
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[5] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@43d9f1a2
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[1] TestData [input=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@13390a96, expected=multi/container-id/element-id]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[2] TestData [input=org.eclipse.set.model.planpro.Signale.impl.SignalImpl@7497a554, expected=multi/456/123]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKeyOther(TestData)[1] TestData [input=Pair [first=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@2fdf7da2, second=other], expected=multi/container-id/element-id/other=other]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKeyOther(TestData)[2] TestData [input=Pair [first=org.eclipse.set.model.planpro.Signale.impl.SignalImpl@584136c1, second=xxx], expected=multi/456/123/other=xxx]

org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[1] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@38eb0f4d
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[2] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@6ad16c5d
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[3] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@3b545206
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[4] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@181d8899
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[5] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@b887730
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[1] TestData [input=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@6eaf030c, expected=multi/container-id/element-id]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[2] TestData [input=org.eclipse.set.model.planpro.Signale.impl.SignalImpl@6dbb3d7d, expected=multi/456/123]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKeyOther(TestData)[1] TestData [input=Pair [first=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@6d9428f3, second=other], expected=multi/container-id/element-id/other=other]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKeyOther(TestData)[2] TestData [input=Pair [first=org.eclipse.set.model.planpro.Signale.impl.SignalImpl@398f0516, second=xxx], expected=multi/456/123/other=xxx]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Optimizer Cache Memory And Application performance

2 participants

@TruongQuangSB