-
Notifications
You must be signed in to change notification settings - Fork 25
feat: added browser-use custom CDP domain + version bump #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
reformedot
wants to merge
5
commits into
main
Choose a base branch
from
feat/custom-cdp-domain
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+10,006
−7,309
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f2dca6b
feat: added browser-use custom CDP domain + option to define CDP vers…
reformedot 89d5732
feat: update CDP specifications and add Taskfile for cache management
reformedot 1d1898c
feat: add format-json task and update JSON protocol files for consist…
reformedot b3ee5c0
fix: add file existence check in JSON formatting task to prevent errors
reformedot f99397f
docs: add version pinning instructions to README for CDP specification
reformedot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| version: "3" | ||
|
|
||
| tasks: | ||
| generate: | ||
| desc: "Regenerate CDP types from protocol definitions" | ||
| cmds: | ||
| - uv run python -m cdp_use.generator | ||
|
|
||
| build: | ||
| desc: "Build the distribution package" | ||
| cmds: | ||
| - uv build | ||
|
|
||
| install: | ||
| desc: "Install package in development mode" | ||
| cmds: | ||
| - uv pip install -e . | ||
|
|
||
| lint: | ||
| desc: "Run ruff linter" | ||
| cmds: | ||
| - uv run ruff check cdp_use/ --statistics | ||
|
|
||
| format: | ||
| desc: "Format code with ruff" | ||
| cmds: | ||
| - uv run ruff format cdp_use/ | ||
|
|
||
| format-json: | ||
| desc: "Format JSON protocol files" | ||
| cmds: | ||
| - | | ||
| for file in cdp_use/custom_protocols/*.json; do | ||
| [ -f "$file" ] || continue | ||
| python3 -m json.tool "$file" "$file.tmp" && mv "$file.tmp" "$file" | ||
| done | ||
|
|
||
| example: | ||
| desc: "Run the simple example" | ||
| cmds: | ||
| - uv run python simple.py | ||
|
|
||
| clean: | ||
| desc: "Clean generated files and build artifacts" | ||
| cmds: | ||
| - rm -rf dist/ build/ *.egg-info | ||
| - find . -type d -name __pycache__ -exec rm -rf {} + 2>/dev/null || true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
format-json fails when no custom protocol files exist because the unmatched glob is treated as a literal path. Add a guard so the loop skips/terminates when no files match.
Prompt for AI agents
✅ Addressed in
b3ee5c0