feat: added browser-use custom CDP domain + version bump #5
+10,006
−7,309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion + updated specification
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this |
@reformedot I've started the AI code review. It'll take a few minutes to complete. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 279 files (reviewed changes from recent commits).
Note: This PR contains a large number of files. cubic only reviews up to 150 files per PR, so some files may not have been reviewed.
Prompt for AI agents (all 1 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="cdp_use/cdp/accessibility/types.py">
<violation number="1" location="cdp_use/cdp/accessibility/types.py:182">
Fix the typo in the AXPropertyName docstring so it reads "node" instead of "noode" to keep the generated documentation accurate.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
| - from 'activedescendant' to 'owns' - relationships between elements other than parent/child/sibling.""" | ||
|
|
||
| - from 'activedescendant' to 'owns': relationships between elements other than parent/child/sibling | ||
| - from 'activeFullscreenElement' to 'uninteresting': reasons why this noode is hidden""" |
There was a problem hiding this comment.
Fix the typo in the AXPropertyName docstring so it reads "node" instead of "noode" to keep the generated documentation accurate.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At cdp_use/cdp/accessibility/types.py, line 182:
<comment>Fix the typo in the AXPropertyName docstring so it reads "node" instead of "noode" to keep the generated documentation accurate.</comment>
<file context>
@@ -89,15 +113,73 @@ class AXValue(TypedDict):
-- from 'activedescendant' to 'owns' - relationships between elements other than parent/child/sibling."""
-
+- from 'activedescendant' to 'owns': relationships between elements other than parent/child/sibling
+- from 'activeFullscreenElement' to 'uninteresting': reasons why this noode is hidden"""
</file context>
Suggested change
| - from 'activeFullscreenElement' to 'uninteresting': reasons why this noode is hidden""" | |
| - from 'activeFullscreenElement' to 'uninteresting': reasons why this node is hidden""" |
There was a problem hiding this comment.
2 issues found across 286 files
Note: This PR contains a large number of files. cubic only reviews up to 150 files per PR, so some files may not have been reviewed.
Prompt for AI agents (all 2 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="Taskfile.yml">
<violation number="1" location="Taskfile.yml:33">
format-json fails when no custom protocol files exist because the unmatched glob is treated as a literal path. Add a guard so the loop skips/terminates when no files match.</violation>
</file>
<file name="cdp_use/cdp/accessibility/types.py">
<violation number="1" location="cdp_use/cdp/accessibility/types.py:182">
The new docstring line describing hidden-node reasons contains a typo (“noode” instead of “node”), which should be corrected for clarity.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
| desc: "Format JSON protocol files" | ||
| cmds: | ||
| - | | ||
| for file in cdp_use/custom_protocols/*.json; do |
There was a problem hiding this comment.
format-json fails when no custom protocol files exist because the unmatched glob is treated as a literal path. Add a guard so the loop skips/terminates when no files match.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At Taskfile.yml, line 33:
<comment>format-json fails when no custom protocol files exist because the unmatched glob is treated as a literal path. Add a guard so the loop skips/terminates when no files match.</comment>
<file context>
@@ -0,0 +1,46 @@
+ desc: "Format JSON protocol files"
+ cmds:
+ - |
+ for file in cdp_use/custom_protocols/*.json; do
+ python3 -m json.tool "$file" "$file.tmp" && mv "$file.tmp" "$file"
+ done
</file context>
✅ Addressed in b3ee5c0
| - from 'activedescendant' to 'owns' - relationships between elements other than parent/child/sibling.""" | ||
|
|
||
| - from 'activedescendant' to 'owns': relationships between elements other than parent/child/sibling | ||
| - from 'activeFullscreenElement' to 'uninteresting': reasons why this noode is hidden""" |
There was a problem hiding this comment.
The new docstring line describing hidden-node reasons contains a typo (“noode” instead of “node”), which should be corrected for clarity.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At cdp_use/cdp/accessibility/types.py, line 182:
<comment>The new docstring line describing hidden-node reasons contains a typo (“noode” instead of “node”), which should be corrected for clarity.</comment>
<file context>
@@ -89,15 +113,73 @@ class AXValue(TypedDict):
-- from 'activedescendant' to 'owns' - relationships between elements other than parent/child/sibling."""
-
+- from 'activedescendant' to 'owns': relationships between elements other than parent/child/sibling
+- from 'activeFullscreenElement' to 'uninteresting': reasons why this noode is hidden"""
</file context>
Suggested change
| - from 'activeFullscreenElement' to 'uninteresting': reasons why this noode is hidden""" | |
| - from 'activeFullscreenElement' to 'uninteresting': reasons why this node is hidden""" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added browser-use custom CDP domain + option to define CDP version + updated specification
Summary by cubic
Adds a custom BrowserUse CDP domain with captcha solver events and lets you pin the CDP spec version used by the generator. Also syncs to the latest CDP APIs and adds a Taskfile for common dev tasks.
New Features
Migration
Written for commit f99397f. Summary will update automatically on new commits.