Skip to content

GH-48627: [Python] Add PyDecimal_Check(pythopn_decimal) as a ARROW_DCHECK #48628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HyukjinKwon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GH-48627: [Python] Add PyDecimal_Check(pythopn_decimal) as a ARROW_DCHECK #48628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/pyarrow/src/arrow/python/decimal.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ static Status InferDecimalPrecisionAndScale(PyObject* python_decimal, int32_t* p
ARROW_DCHECK_NE(python_decimal, NULLPTR);
ARROW_DCHECK_NE(precision, NULLPTR);
ARROW_DCHECK_NE(scale, NULLPTR);
ARROW_DCHECK(PyDecimal_Check(python_decimal))
<< "python_decimal is not an instance of decimal.Decimal";

// TODO(phillipc): Make sure we perform PyDecimal_Check(python_decimal) as a
// ARROW_DCHECK
OwnedRef as_tuple(PyObject_CallMethod(python_decimal, const_cast<char*>("as_tuple"),
const_cast<char*>("")));
RETURN_IF_PYERROR();
Expand Down
Loading