GH-48627: [Python] Add PyDecimal_Check(pythopn_decimal) as a ARROW_DCHECK #48628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
A 7-year-old TODO suggested adding a type validation assertion in
InferDecimalPrecisionAndScale(). This helps catch type errors during development in debug builds.What changes are included in this PR?
Added
ARROW_DCHECK(PyDecimal_Check(python_decimal))assertion inInferDecimalPrecisionAndScale()to validate that the input is adecimal.Decimalinstance.This resolves the TODO added in commit 9515fe9
Are these changes tested?
Yes. Existing tests in
python_test.ccalready execute this code path throughDecimalMetadata::Update(). The assertion is debug-only and doesn't change runtime behavior.Are there any user-facing changes?
No, dev-only.