Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Mar 25, 2023

No description provided.

@ghost
Copy link
Author

ghost commented Mar 25, 2023

The.. failing check seems unrelated to my changes?

@zesterer
Copy link
Owner

Thanks! Looks like it might need a fmt pass or something?

@m-hugo
Copy link

m-hugo commented Mar 26, 2023

Thanks! Looks like it might need a fmt pass or something?

?, it's a clippy error, since rust-lang/rust-clippy#10520 it thinks src/private.rs:280:18 is UB
280 | unsafe { MaybeUninit::uninit().assume_init() }

@wackbyte wackbyte mentioned this pull request Mar 26, 2023
@zesterer
Copy link
Owner

it thinks src/private.rs:280:18 is UB

That's frustrating. It would be nice if clippy checked the self type.

@zesterer
Copy link
Owner

This is now fixed on main, so after a rebase CI should pass.

@ghost
Copy link
Author

ghost commented Mar 26, 2023

Merged, should pass CI now

@zesterer zesterer merged commit f12371c into zesterer:main Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants