Skip to content

Conversation

@alexkrnet
Copy link

This PR adds an option to JSONWriter class for beautiful (intended) json output.

@goofballLogic
Copy link
Contributor

Rather than developing a long list of flags for the method, might be nice to have a non static version of the class which can be configured?
Con: Although it might mean that the (valuable) cut'n'paste option would be harder.
Pro: It would also allow for dependency injection.

@JD-Howard
Copy link

This PR adds an option to JSONWriter class for beautiful (intended) json output.

I know this is old, but just wanted to say thank you.

This was the a perfectly isolated addition that just works. It would be more optimal for it to be fully integrated, but such a beautiful thing when a major feature is entirely cut/paste like this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants