Skip to content

Conversation

@vjik
Copy link
Member

@vjik vjik commented Nov 25, 2025

Q A
Is bugfix?
New feature?
Breaks BC? ✔️

Related to yiisoft/db#1108

@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.66%. Comparing base (0f41835) to head (3c10198).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #416      +/-   ##
============================================
+ Coverage     98.62%   98.66%   +0.03%     
- Complexity      247      249       +2     
============================================
  Files            26       27       +1     
  Lines           800      823      +23     
============================================
+ Hits            789      812      +23     
  Misses           11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samdark samdark requested a review from Copilot November 25, 2025 21:17
Copilot finished reviewing on behalf of samdark November 25, 2025 21:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a ColumnDefinitionParser class for MS SQL Server to parse column type definitions and their parameters. This is part of the broader refactoring in the yiisoft/db package (related to PR #1108).

Key Changes

  • Implements ColumnDefinitionParser class extending AbstractColumnDefinitionParser to handle MSSQL-specific type parameter parsing
  • Integrates the parser into ColumnFactory via the columnDefinitionParser() method
  • Adds test coverage through ColumnDefinitionParserTest extending common test base

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

File Description
src/Column/ColumnDefinitionParser.php New parser class implementing parseTypeParams() to handle size/precision/scale parsing for MSSQL column types
src/Column/ColumnFactory.php Adds columnDefinitionParser() method to instantiate and return the new parser
tests/ColumnDefinitionParserTest.php New test class extending common test base to verify parser functionality
CHANGELOG.md Documents the addition of ColumnDefinitionParser class in version 2.0.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vjik vjik requested a review from a team November 25, 2025 21:37
@vjik vjik added the status:code review The pull request needs review. label Nov 25, 2025
@vjik vjik requested a review from samdark November 25, 2025 21:37
@vjik vjik added status:under development Someone is working on a pull request. and removed status:code review The pull request needs review. labels Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:under development Someone is working on a pull request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants