XSI-2093: CA-422229: Host should not register all IPs to DNS server

[liulinC]

Fixes: cba2f1d
During fix the localhost name issue, An problem was found Hosts in a pool can not resovle each other with static IP Thus, an enhancement is applied to push host name and IPs to DNS, This pushed all IPs of the host into DNS server, including the storage interface.

This commit just revert the DNS change.
Regarding the resovle issue with static IP, it better goes to somewhere else like network event hook, or system deamon, if we do care about it and want a fix.

[MarkSymsCtx]

Is this actually what we want to do? Registering the DNS for the management interface IP doesn't seem to have been causing an issue just when this was done for all the other IP addresses that the host has. The ads command allows you to specify the host name and IP to register so we could just restrict the registration in that way and solve both issues?

[liulinC]

Is this actually what we want to do? Registering the DNS for the management interface IP doesn't seem to have been causing an issue just when this was done for all the other IP addresses that the host has. The ads command allows you to specify the host name and IP to register so we could just restrict the registration in that way and solve both issues?

Yeah, I also considered that option,
However, Refer to the comments, if we do want to register management to DNS, that should NOT be part of external auth logic.
That should be a network event hook or Dom0 service, or xcp-networkd, e.g: We want to register management interface to DNS with static IP, no matter join AD or not. We can have future enchantment if we want this, but surely, not here.

[robhoes]

I agree: I did not expect the AD code to update DNS servers (and didn't notice that change going in...). The AD code should just do auth and is not the right place for network (re)configuration.