ocaml: remove List.hd usages #6785
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindig
approved these changes
Dec 9, 2025
psafont
force-pushed
the
dev/pau/quality
branch
6 times, most recently
from
700e665 to
3829326
Compare
Member
Author
|
Found an issue, I need to add a function in listext, with unit-tests |
psafont
force-pushed
the
dev/pau/quality
branch
2 times, most recently
from
83e0ec8 to
9504ce0
Compare
This function is useful to apply a function to a list that may fail, it returns the first error, or all the successful results. Signed-off-by: Pau Ruiz Safont <pau.safont@vates.tech>
This makes the exception much more recognizable and easier to locate. Signed-off-by: Pau Ruiz Safont <pau.safont@vates.tech>
These can be easily replaced with a match against the list, or changing parameters to separate the head from the rest of the list Signed-off-by: Pau Ruiz Safont <pau.safont@vates.tech>
Previously an exception was raised for last, head is a new function. Also adds a latest_release to datamodel_types that can't fail after the module has been loaded. (the list is populated so it won't fail when the module is loaded either) Signed-off-by: Pau Ruiz Safont <pau.safont@vates.tech>
This forces users to deal with None in the new code. One of them is replace with the new function List.try_map that returns the first error. While split_on_char never returns an empty list, it's a good test for using try_map Signed-off-by: Pau Ruiz Safont <pau.safont@vates.tech>
The return type is the same, but it's more obvious to see what it does Signed-off-by: Pau Ruiz Safont <pau.safont@vates.tech>
psafont
force-pushed
the
dev/pau/quality
branch
from
9504ce0 to
dec6b8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by using options and avoiding exceptions as much as possible, or using custom exceptions that help finding the cause.