Skip to content

fix for wait_container_is_ready decorator being depreciated #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sylphia-nox wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix for wait_container_is_ready decorator being depreciated #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,15 @@ classifiers = [
"Topic :: Software Development :: Quality Assurance",
"Topic :: Software Development :: Libraries :: Python Modules",
]
requires-python = ">=3.9, <3.14"
requires-python = ">=3.9.2, <3.14"
dependencies = [
"requests>=2.32.4"
]

[project.optional-dependencies]
testing = [
"docker>=7.1.0",
"testcontainers>=3.7.1,<4.0.0",
"testcontainers>=4.13.2",
]

[dependency-groups]
Expand Down
4 changes: 2 additions & 2 deletions wiremock/testing/testcontainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
import requests
from testcontainers.core.container import DockerContainer
from testcontainers.core.exceptions import ContainerStartException
from testcontainers.core.waiting_utils import wait_container_is_ready
from testcontainers.core.wait_strategies import HttpWaitStrategy

from wiremock.resources.mappings.models import Mapping

Expand Down Expand Up @@ -187,7 +187,6 @@ def reload_mappings(self) -> requests.Response:

return resp

@wait_container_is_ready()
def configure(self) -> None:
if not self.server_running():
raise WireMockContainerException(
Expand Down Expand Up @@ -221,6 +220,7 @@ def get_url(self, path: str) -> str:
def start(self, cmd: Optional[str] = None) -> "WireMockContainer":
self.with_command(cmd)
super().start()
self.waiting_for(HttpWaitStrategy(self.https_server_port if self.secure else self.http_server_port))
self.configure()
return self

Expand Down