-
Notifications
You must be signed in to change notification settings - Fork 4
Add some best practices #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh-pages
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for w3c-string-search ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
… into xfq/best-practices
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
aphillips
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments.
Note: best practices with no id attribute can't be externally linked, which is not ideal.
index.html
Outdated
| <section id="caseVariation"> | ||
| <h4>Case Folding</h4> | ||
|
|
||
| <p class="advisement">By default, string searching SHOULD be case-insensitive using Unicode's case-folding algorithms.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is complicated. Unicode's case-folding algorithms provide defaults, but, as we discuss later, there are at least some locale-specific foldings (which, I suppose, one could consider part of Unicode's case-folds......)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about something like this:
By default, string searching SHOULD be case-insensitive. Implementations SHOULD use Unicode's default case-folding algorithms, with locale-specific tailorings applied when the language context is known.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's a good overall statement, but it's making the advisement do too many thing. Perhaps break it up like:
- Allow users to switch between case-insensitive and case-sensitive searching
- Make string searching case-insensitive by default
- Use Unicode's default "full" case-fold for case-insensitive searching by default (where full is defined as common plus full mappings)
- Optionally apply locale-specific tailorings of Unicode's "full" case-fold for case-insensitive searching when the language is known.
- Use Turkic case folding where needed (more work needed for this one)
No description provided.