Formal definition of the evaluation of EXISTS expressions #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
rubensworks
approved these changes
Dec 12, 2025
Member
rubensworks
left a comment
rubensworks
left a comment
There was a problem hiding this comment.
We should also make sure that this update to the definition of EXISTS is also mentioned in the changelog. (fine for me if you prefer doing that in the final PR for #302)
Tpt
approved these changes
Dec 12, 2025
Co-authored-by: Thomas Tanon <thomas@pellissier-tanon.fr>
Contributor
Author
hartig
commented
Dec 18, 2025
TallTed
suggested changes
Dec 18, 2025
Comment on lines
+5693
to
+5694
| No additional binding of variables occurs. The <code>NOT EXISTS</code> form | ||
| translates into <code>fn:<a data-cite="XPATH-FUNCTIONS-31#func-not">fn:not</a>(EXISTS {...})</code>.</p> |
Member
There was a problem hiding this comment.
Suggested change
| No additional binding of variables occurs. The <code>NOT EXISTS</code> form | |
| translates into <code>fn:<a data-cite="XPATH-FUNCTIONS-31#func-not">fn:not</a>(EXISTS {...})</code>.</p> | |
| No additional binding of variables occurs. The `NOT EXISTS` form | |
| translates into <code>fn:<a data-cite="XPATH-FUNCTIONS-31#func-not">fn:not</a>(EXISTS {...})</cde>.</p> |
Comment on lines
+5700
to
5701
| <p><code>NOT EXISTS { pattern }</code> is equivalent to <code><a data-cite="XPATH-FUNCTIONS-31#func-not">fn:not</a>(EXISTS { pattern | ||
| })</code>.</p> |
Member
There was a problem hiding this comment.
Suggested change
| <p><code>NOT EXISTS { pattern }</code> is equivalent to <code><a data-cite="XPATH-FUNCTIONS-31#func-not">fn:not</a>(EXISTS { pattern | |
| })</code>.</p> | |
| <p>`NOT EXISTS { pattern }` is equivalent to <code><a data-cite="XPATH-FUNCTIONS-31#func-not">fn:not</a>(EXISTS { pattern | |
| })</code>.</p> |
TallTed
reviewed
Dec 18, 2025
Comment on lines
+5716
to
+5717
| <a href="#defn_eval" class="evalFct">eval</a>(|D|(|G|), |A|, <var>μ</var>) is not empty, | ||
| and</li> |
Member
There was a problem hiding this comment.
Suggested change
| <a href="#defn_eval" class="evalFct">eval</a>(|D|(|G|), |A|, <var>μ</var>) is not empty, | |
| and</li> | |
| <a href="#defn_eval" class="evalFct">eval</a>(|D|(|G|), |A|, <var>μ</var>) is not empty</li> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements step 5 of #302. That is, it adds the formal definition of the evaluation of EXISTS expressions into Section 17.4.1.4 NOT EXISTS and EXISTS.
Additionally, the PR removes some text that is now obsolete in that section, and it adds a Note at the beginning of Section 18.6.2 Evaluation Semantics to clarify that the evaluation of EXISTS changes the context solution mapping μctx that is passed to the eval function.
Preview | Diff