[Do NOT merge yet] FIX: Allow sparse data on TSNE #2827
+1
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The docs say that TSNE does not support sparse inputs, and there are checks against them.
But it turns out that TSNE doesn't use the actual data - instead, it has some preliminary stages where it calculates distances or neighbors or PCA, and the results from those are then used to generate arrays that are passed to the actual TSNE algorithm. Those arrays are always dense, regardless of how the data comes in originally, so in way sklearnex has partial support for sparse data on TSNE.
This PR corrects the docs and removes the checks for sparsity.
Note: this is not ready to be merged yet.
Checklist:
Completeness and readability
Testing