Skip to content

Conversation

@david-cortes-intel
Copy link
Contributor

Description

The docs say that TSNE does not support sparse inputs, and there are checks against them.

But it turns out that TSNE doesn't use the actual data - instead, it has some preliminary stages where it calculates distances or neighbors or PCA, and the results from those are then used to generate arrays that are passed to the actual TSNE algorithm. Those arrays are always dense, regardless of how the data comes in originally, so in way sklearnex has partial support for sparse data on TSNE.

This PR corrects the docs and removes the checks for sparsity.

Note: this is not ready to be merged yet.


Checklist:

Completeness and readability

  • I have updated the documentation to reflect the changes or created a separate PR with updates and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

@david-cortes-intel david-cortes-intel added the bug Something isn't working label Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant