Skip to content

Update depedency versions #1654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Oksamies wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update depedency versions #1654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions apps/cyberstorm-remix/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@
"dependencies": {
"@fortawesome/pro-light-svg-icons": "7.1.0",
"@fortawesome/pro-solid-svg-icons": "7.1.0",
"@react-router/node": "^7.6.2",
"@react-router/serve": "^7.6.2",
"@sentry/remix": "^10.8.0",
"@sentry/vite-plugin": "^4.3.0",
"@react-router/node": "^7.10.0",
"@react-router/serve": "^7.10.0",
"@sentry/remix": "^10.28.0",
"@sentry/vite-plugin": "^4.6.1",
"@thunderstore/cyberstorm": "^0.1.0",
"@thunderstore/cyberstorm-theme": "^0.1.0",
"@thunderstore/dapper": "^0.1.0",
Expand All @@ -30,27 +30,27 @@
"buffer": "^6.0.3",
"hast-util-sanitize": "5.0.2",
"isbot": "^5.1.17",
"react": "^19.1.0",
"react-dom": "^19.1.0",
"react": "^19.2.1",
"react-dom": "^19.2.1",
"react-markdown": "^10.1.0",
"react-router": "^7.6.2",
"react-router": "^7.10.0",
"react-syntax-highlighter": "15.6.6",
"rehype-sanitize": "^6.0.0",
"remark-gfm": "^4.0.1",
"remix-utils": "^7.7.0",
"remix-utils": "^9.0.0",
"semver": "^7.7.1",
"zod": "^3.23.8"
},
"devDependencies": {
"@react-router/dev": "^7.0.0",
"@types/react": "^19.1.0",
"@types/react-dom": "19.1.9",
"@react-router/dev": "^7.10.0",
"@types/react": "^19.2.7",
"@types/react-dom": "19.2.3",
"@vitest/browser": "3.2.4",
"@vitest/coverage-v8": "3.2.4",
"playwright": "1.55.1",
"typescript": "^5.6.2",
"typescript-plugin-css-modules": "^5.1.0",
"vite": "7.1.7",
"vite": "7.2.6",
"vite-tsconfig-paths": "^5.0.1",
"vitest": "3.2.4"
},
Expand Down
10 changes: 5 additions & 5 deletions apps/storybook/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,17 @@
"@storybook/react-vite": "9.1.8",
"@thunderstore/cyberstorm": "0.1.0",
"@thunderstore/cyberstorm-theme": "0.1.0",
"@types/react": "^19.1.0",
"@types/react-dom": "19.1.9",
"@types/react": "^19.2.7",
"@types/react-dom": "19.2.3",
"@vitejs/plugin-react": "5.0.3",
"chromatic": "^13.2.0",
"globals": "^16.4.0",
"react": "^19.1.0",
"react-dom": "^19.1.0",
"react": "^19.2.1",
"react-dom": "^19.2.1",
"storybook": "9.1.8",
"typescript": "^5.6.2",
"typescript-eslint": "8.44.0",
"vite": "7.1.7"
"vite": "7.2.6"
},
"repository": "https://github.com/thunderstore-io/thunderstore-ui/tree/master/apps/storybook"
}
6 changes: 3 additions & 3 deletions packages/cyberstorm-forms/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@
"@thunderstore/ts-api-react-actions": "^0.1.0",
"@thunderstore/ts-api-react-forms": "^0.1.0",
"@thunderstore/use-promise": "^0.1.0",
"@types/react": "^19.1.0",
"react": "^19.1.0",
"react-dom": "^19.1.0",
"@types/react": "^19.2.7",
"react": "^19.2.1",
"react-dom": "^19.2.1",
"react-hook-form": "^7.53.0",
"styled-components": "^6.1.13",
"zod": "^3.23.8"
Expand Down
6 changes: 3 additions & 3 deletions packages/cyberstorm/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,11 @@
"@thunderstore/thunderstore-api": "*",
"@thunderstore/use-promise": "^0.1.0",
"@types/node": "^20.16.0",
"@types/react": "^19.1.0",
"@types/react": "^19.2.7",
"@types/uuid": "^10.0.0",
"react": "^19.1.0",
"react": "^19.2.1",
"react-data-table-component": "^7.6.2",
"react-dom": "^19.1.0",
"react-dom": "^19.2.1",
"react-syntax-highlighter": "15.6.6",
"s-ago": "^2.2.0",
"styled-components": "^6.1.13",
Expand Down
6 changes: 3 additions & 3 deletions packages/dapper/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@
},
"dependencies": {
"@babel/runtime": "^7.25.6",
"@types/react": "^19.1.0",
"react": "^19.1.0",
"react-dom": "^19.1.0"
"@types/react": "^19.2.7",
"react": "^19.2.1",
"react-dom": "^19.2.1"
},
"preconstruct": {
"entrypoints": [
Expand Down
6 changes: 3 additions & 3 deletions packages/react-dnd/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
"dev": "tsc --watch"
},
"dependencies": {
"@types/react": "^19.1.0",
"react": "^19.1.0",
"react-dom": "^19.1.0"
"@types/react": "^19.2.7",
"react": "^19.2.1",
"react-dom": "^19.2.1"
},
"devDependencies": {
"typescript-plugin-css-modules": "^5.1.0"
Expand Down
6 changes: 3 additions & 3 deletions packages/ts-api-react-actions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
"@babel/runtime": "^7.25.6",
"@thunderstore/thunderstore-api": "*",
"@thunderstore/ts-api-react": "*",
"@types/react": "^19.1.0",
"react": "^19.1.0",
"react-dom": "^19.1.0",
"@types/react": "^19.2.7",
"react": "^19.2.1",
"react-dom": "^19.2.1",
"zod": "^3.23.8"
}
}
6 changes: 3 additions & 3 deletions packages/ts-api-react-forms/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
"@hookform/resolvers": "^3.9.0",
"@thunderstore/thunderstore-api": "*",
"@thunderstore/ts-api-react": "*",
"@types/react": "^19.1.0",
"react": "^19.1.0",
"react-dom": "^19.1.0",
"@types/react": "^19.2.7",
"react": "^19.2.1",
"react-dom": "^19.2.1",
"react-hook-form": "^7.53.0",
"zod": "^3.23.8"
},
Expand Down
6 changes: 3 additions & 3 deletions packages/ts-api-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
"@thunderstore/dapper": "^0.1.0",
"@thunderstore/dapper-ts": "^0.1.0",
"@thunderstore/thunderstore-api": "^0.1.0",
"@types/react": "^19.1.0",
"react": "^19.1.0",
"react-dom": "^19.1.0"
"@types/react": "^19.2.7",
"react": "^19.2.1",
"react-dom": "^19.2.1"
},
"devDependencies": {
"typescript": "^5.6.2",
Expand Down
6 changes: 3 additions & 3 deletions packages/ts-uploader-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
},
"dependencies": {
"@thunderstore/ts-uploader": "*",
"@types/react": "^19.1.0",
"react": "^19.1.0",
"react-dom": "^19.1.0"
"@types/react": "^19.2.7",
"react": "^19.2.1",
"react-dom": "^19.2.1"
},
"devDependencies": {
"typescript-plugin-css-modules": "^5.1.0"
Expand Down
4 changes: 2 additions & 2 deletions plop/package/package.json.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
{{/each}}
{{#if isReact}}
"@types/react": "^18.0.0",
"react": "^18.2.0",
"react-dom": "^18.2.0"
"react": "^19.2.1",
"react-dom": "^19.2.1"
Comment on lines 21 to +23
Copy link

@graphite-app graphite-app bot Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type definition version mismatch detected. The @types/react is still at ^18.0.0 while react and react-dom have been updated to ^19.2.1. This will cause TypeScript compilation errors due to incompatible type definitions.

Fix:

"@types/react": "^19.2.7",
"react": "^19.2.1",
"react-dom": "^19.2.1"
Suggested change
"@types/react": "^18.0.0",
"react": "^18.2.0",
"react-dom": "^18.2.0"
"react": "^19.2.1",
"react-dom": "^19.2.1"
"@types/react": "^19.2.7",
"react": "^19.2.1",
"react-dom": "^19.2.1"

Spotted by Graphite Agent

Fix in Graphite

Is this helpful? React 👍 or 👎 to let us know.

Comment on lines 21 to +23
Copy link

@coderabbitai coderabbitai bot Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

# Search for @types/react references across package.json files
fd -e "package.json" -o -e "package.json.hbs" --type f | head -20 | xargs -I {} sh -c 'echo "=== {} ===" && cat "{}" | grep -A 1 -B 1 "@types/react" 2>/dev/null || echo "no match"'

Repository: thunderstore-io/thunderstore-ui

Length of output: 191

🏁 Script executed:

# Get a broader view: search for @types/react in all package.json files
rg "@types/react" --type json -A 1 -B 1

Repository: thunderstore-io/thunderstore-ui

Length of output: 2666

Align @types/react version in the template with React 19.2.x

The template currently scaffolds:

  • @types/react: ^18.0.0
  • react: ^19.2.1
  • react-dom: ^19.2.1

Any new React package generated from this template will have React 19.2.x at runtime but React 18 type definitions. All other packages in the repo use @types/react@^19.2.7, creating an inconsistency that can lead to type mismatches.

Update to keep them in sync:

-    "@types/react": "^18.0.0",
+    "@types/react": "^19.2.7",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"@types/react": "^18.0.0",
"react": "^18.2.0",
"react-dom": "^18.2.0"
"react": "^19.2.1",
"react-dom": "^19.2.1"
"@types/react": "^19.2.7",
"react": "^19.2.1",
"react-dom": "^19.2.1"
🤖 Prompt for AI Agents 
In plop/package/package.json.hbs around lines 21 to 23, the template pins
@types/react to ^18.0.0 while react and react-dom are ^19.2.1, causing
type/runtime mismatch; update the @types/react entry to match the repo's React
19.x (e.g. ^19.2.7 or ^19.2.x) so the generated package.json uses @types/react
compatible with React 19, and run a quick template lint or install to verify no
type errors.

{{/if}}
},
"devDependencies": {
Expand Down
Loading
Loading