Merge pull request #1664 from thunderstore-io/team-blank-donation-url

thunderstore-api: allow null values for team donation link

Author: anttimaki

apps/cyberstorm-remix/app/settings/teams/team/tabs/Profile/Profile.tsx

@@ -90,6 +90,9 @@ function ProfileForm(props: { team: TeamDetails }) {
     InputErrors
   >({
     inputs: formInputs,
+    refiner: async (inputs: typeof formInputs) => ({
+      donation_link: nullForEmptyString(inputs.donation_link),
+    }),
     submitor,
     onSubmitSuccess: () => {
       toast.addToast({
@@ -120,7 +123,7 @@ function ProfileForm(props: { team: TeamDetails }) {
             <NewTextInput
               name={"donation_link"}
               placeholder={"https://"}
-              value={formInputs.donation_link}
+              value={formInputs.donation_link ?? ""}
               onChange={(e) =>
                 updateFormFieldState({
                   field: "donation_link",
@@ -140,3 +143,6 @@ function ProfileForm(props: { team: TeamDetails }) {
 }
 
 ProfileForm.displayName = "ProfileForm";
+
+const nullForEmptyString = (value: string | null): string | null =>
+  value?.trim() === "" ? null : value;

packages/thunderstore-api/src/schemas/requestSchemas.ts

@@ -622,7 +622,7 @@ export type TeamDetailsEditRequestParams = z.infer<
 >;
 
 export const teamDetailsEditRequestDataSchema = z.object({
-  donation_link: z.string().min(1).max(1024),
+  donation_link: z.string().min(1).max(1024).nullable(),
 });
 
 export type TeamDetailsEditRequestData = z.infer<

packages/thunderstore-api/src/schemas/responseSchemas.ts

@@ -353,7 +353,7 @@ export type MarkdownRenderResponseData = z.infer<
 
 // TeamDetailsEditResponse
 export const teamDetailsEditResponseSchema = z.object({
-  donation_link: z.string().min(1).max(1024),
+  donation_link: z.string().min(1).max(1024).nullable(),
 });
 
 export type TeamDetailsEditResponseData = z.infer<