thunderstore-api: allow null values for team donation link

The backend uses Django's cursed null=True for saving the donation
link, so submitting empty string will fail on save (or even earlier by
the validation done by serializer) unless it is cast to null. At least
earlier a design principle has been that API does what it does, and the
clients should adjust their behaviour to match the API. It's also seems
to be cleaner to do the casting here.

Author: anttimaki

apps/cyberstorm-remix/app/settings/teams/team/tabs/Profile/Profile.tsx

@@ -90,6 +90,9 @@ function ProfileForm(props: { team: TeamDetails }) {
     InputErrors
   >({
     inputs: formInputs,
+    refiner: async (inputs: typeof formInputs) => ({
+      donation_link: nullForEmptyString(inputs.donation_link),
+    }),
     submitor,
     onSubmitSuccess: () => {
       toast.addToast({
@@ -120,7 +123,7 @@ function ProfileForm(props: { team: TeamDetails }) {
             <NewTextInput
               name={"donation_link"}
               placeholder={"https://"}
-              value={formInputs.donation_link}
+              value={formInputs.donation_link ?? ""}
               onChange={(e) =>
                 updateFormFieldState({
                   field: "donation_link",
@@ -140,3 +143,6 @@ function ProfileForm(props: { team: TeamDetails }) {
 }
 
 ProfileForm.displayName = "ProfileForm";
+
+const nullForEmptyString = (value: string | null): string | null =>
+  value?.trim() === "" ? null : value;

packages/thunderstore-api/src/schemas/requestSchemas.ts

@@ -622,7 +622,7 @@ export type TeamDetailsEditRequestParams = z.infer<
 >;
 
 export const teamDetailsEditRequestDataSchema = z.object({
-  donation_link: z.string().min(1).max(1024),
+  donation_link: z.string().min(1).max(1024).nullable(),
 });
 
 export type TeamDetailsEditRequestData = z.infer<

packages/thunderstore-api/src/schemas/responseSchemas.ts

@@ -353,7 +353,7 @@ export type MarkdownRenderResponseData = z.infer<
 
 // TeamDetailsEditResponse
 export const teamDetailsEditResponseSchema = z.object({
-  donation_link: z.string().min(1).max(1024),
+  donation_link: z.string().min(1).max(1024).nullable(),
 });
 
 export type TeamDetailsEditResponseData = z.infer<