Skip to content

Conversation

@homersimpsons
Copy link
Collaborator

@homersimpsons homersimpsons commented Dec 17, 2025

@homersimpsons
Copy link
Collaborator Author

Well, phpstan does not seem happy anymore:

Parameter #1 $object of function get_class expects object, mixed given.

But $dummyResponseWithRequest is guaranteed to be a ResponseInterface so this is an object.

@andrew-demb
Copy link
Collaborator

Phpstan doesn't know anything about the result - there is no installed dependency and no any version restrictions.

You can use get_debug_type instead.


What I'm thinking about - why should we stick with cherry-pick instead of merge? Merge will help to know that there are no missed commits in the history between old and new branches.

@homersimpsons
Copy link
Collaborator Author

homersimpsons commented Dec 17, 2025

Phpstan doesn't know anything about the result - there is no installed dependency and no any version restrictions.
You can use get_debug_type instead.

Oh in fact it does not know the dependency... I switched to get_debug_type in the merge.

What I'm thinking about - why should we stick with cherry-pick instead of merge? Merge will help to know that there are no missed commits in the history between old and new branches.

Okay I will do a merge then:

  • I moved the UploadMiddlewareUtils/ directory to src/
  • I resolved the conflicts

# Conflicts:
#	composer.json
#	src/Controller/GraphQLiteController.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants