Support async setUp/tearDown validation with Deferreds #552
+130
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue where setUp/tearDown validation failed when using AsynchronousDeferredRunTest with Deferred-based async upcalls. The validation logic now detects when setUp() or tearDown() returns a Deferred-like object (duck-typing via addBoth method) and defers the validation check until after the Deferred resolves. This allows patterns where super().setUp() or super().tearDown() is called asynchronously via callback chains. For synchronous cases, validation continues to happen immediately as before. Fixes #547
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where setUp/tearDown validation failed when using AsynchronousDeferredRunTest with Deferred-based async upcalls.
The validation logic now detects when setUp() or tearDown() returns a Deferred-like object (duck-typing via addBoth method) and defers the validation check until after the Deferred resolves. This allows patterns where super().setUp() or super().tearDown() is called asynchronously via callback chains.
For synchronous cases, validation continues to happen immediately as before.
Fixes #547