Skip to content

Conversation

@marwinpinlac-web
Copy link
Contributor

Updated the file: audio.md

Added new images and removed unnecessary command line images.

Copy link
Contributor

@Socialhappiness Socialhappiness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested re-ordering and a few corrections, but this is a great update, good job!

Copy link
Contributor

@Socialhappiness Socialhappiness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes with reordering look good!

@jacobgkau
Copy link
Member

@marwinpinlac-web I made a few small tweaks, and this is almost ready. When you have time, could you please update the Launcher and Settings screenshots to show COSMIC, and if you still have the original screenshots for the rest of the new ones you're adding, please bring them in again at their full size instead of the reduced resolution?

@jacobgkau
Copy link
Member

jacobgkau commented Dec 16, 2025

@marwinpinlac-web Screenshots that are more than a megabyte should be converted to JPG so they take up less space/bandwidth. You can do this by opening the file and doing a "Save as..." I've gone ahead and done it for you this time.

Edit: My next commit ran optipng on the remaining PNGs to reduce their size as well. This is a lossless command.

Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All review feedback's been addressed, and I didn't see anything else sticking out while reading through the article.

@jacobgkau jacobgkau requested a review from a team December 16, 2025 22:55
@jacobgkau
Copy link
Member

I'm not sure if adding the word "guide" to the article title is really useful or necessary, but I'm not strongly opposed to it. We may want to consider whether other similarly-named articles, like the current "Bluetooth Troubleshooting", should also be changed similarly in the future.

Copy link
Contributor

@Socialhappiness Socialhappiness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Socialhappiness Socialhappiness merged commit a423692 into master Dec 17, 2025
3 checks passed
@Socialhappiness Socialhappiness deleted the marwinpinlac-web-patch-2 branch December 17, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants