-
Notifications
You must be signed in to change notification settings - Fork 417
Update on Audio Troubleshooting Guide #1336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Socialhappiness
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested re-ordering and a few corrections, but this is a great update, good job!
Socialhappiness
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes with reordering look good!
|
@marwinpinlac-web I made a few small tweaks, and this is almost ready. When you have time, could you please update the Launcher and Settings screenshots to show COSMIC, and if you still have the original screenshots for the rest of the new ones you're adding, please bring them in again at their full size instead of the reduced resolution? |
…nd removed images that are not in use.
… the comments on the recent review
d08ed5a to
f9c8e92
Compare
|
@marwinpinlac-web Screenshots that are more than a megabyte should be converted to JPG so they take up less space/bandwidth. You can do this by opening the file and doing a "Save as..." I've gone ahead and done it for you this time. Edit: My next commit ran |
jacobgkau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All review feedback's been addressed, and I didn't see anything else sticking out while reading through the article.
|
I'm not sure if adding the word "guide" to the article title is really useful or necessary, but I'm not strongly opposed to it. We may want to consider whether other similarly-named articles, like the current "Bluetooth Troubleshooting", should also be changed similarly in the future. |
Socialhappiness
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Updated the file: audio.md
Added new images and removed unnecessary command line images.