Skip to content

Disallow asynchronous import statements #2017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewbastien merged 2 commits into from
Dec 20, 2025
+4 −1
Merged

Disallow asynchronous import statements #2017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
065d543
disallow asynchronous import statements
matthewbastien Dec 19, 2025
a21b604
remove an existing async import
matthewbastien Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@
{
"selector": "CallExpression[callee.object.object.callee.name='tag'][callee.property.name='only']",
"message": "Unexpected exclusive mocha test with tag().suite.only() or tag().test.only()"
},
{
"selector": "ImportExpression",
"message": "Dynamic imports using 'import()' are not allowed. Use static imports at the top of the file instead."
}
],
"@typescript-eslint/no-floating-promises": ["warn", { "checkThenables": true }],
Expand Down
1 change: 0 additions & 1 deletion test/unit-tests/toolchain/BuildFlags.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,7 +571,6 @@ suite("BuildFlags Test Suite", () => {

// Mock execSwift to throw an error
execSwiftSpy = sinon.spy(() => Promise.reject(new Error("Command failed")));
const utilities = await import("@src/utilities/utilities");
sinon.replace(utilities, "execSwift", execSwiftSpy);

const log = instance(logger);
Expand Down