New FP Parsing: Use relevant part of a substring #86018
Open
+19
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@milseman I would appreciate if someone could double-check my use of internal String APIs here. In particular, I've not made any effort to test cases where a string is not "fast UTF8" capable; advice appreciated. |
Contributor
Author
|
This is a follow-on to #85797 |
tbkka
commented
Dec 12, 2025
| } else { | ||
| // Otherwise, make a copy so we have contiguous UTF8... | ||
| let string = String(text) | ||
| parsed = unsafe string._guts.withFastUTF8 { chars -> ${Self}? in |
Contributor
Author
There was a problem hiding this comment.
In particular, can I reliably assume that a copied string will always support withFastUTF8?
tbkka
commented
Dec 12, 2025
| expectNotNil(parsed) | ||
| expectEqual(parsed!.bitPattern, (2.0).bitPattern) | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Do I need to test bridged strings specially here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new FP parsing code inadvertently used the entire backing string, even when the substring referred to just a portion.