Skip to content

[6.3] [SourceKit] Allow converting functions containing shorthand ifs to async #86014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hamishknight wants to merge 1 commit into
base: release/6.3
Choose a base branch
from
Open

[6.3] [SourceKit] Allow converting functions containing shorthand ifs to async #86014

hamishknight wants to merge 1 commit into from
+70 −31

Conversation

@hamishknight
Copy link
Contributor

@hamishknight hamishknight commented Dec 12, 2025 •
edited
Loading

6.3 cherry-pick of #85973

  • Explanation: Fixes a crash that could occur when attempting to perform an async refactoring on a function containing a shorthand conditional binding e.g if let x {}
  • Scope: Affects async refactoring
  • Issue: rdar://154753663
  • Risk: Low, the fix is fairly straightforward and should only affect async refactoring
  • Testing: Added tests to test suite
  • Reviewer: Hamish Knight

@hamishknight hamishknight requested a review from hborla December 12, 2025 17:24
@hamishknight hamishknight requested a review from a team as a code owner December 12, 2025 17:24
@hamishknight hamishknight added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.3 labels Dec 12, 2025
@hamishknight
Copy link
Contributor Author

hamishknight commented Dec 12, 2025

@swift-ci please test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hborla hborla hborla approved these changes

Assignees

No one assigned

Labels

🍒 release cherry pick Flag: Release branch cherry picks swift 6.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hamishknight @hborla @bnbarham