Skip to content

Conversation

@hamishknight
Copy link
Contributor

6.3 cherry-pick of #86011

  • Explanation: Fixes a 6.3 regression that could cause a recursive dynamic member lookup to crash if there's a single viable subscript
  • Scope: Affects key-path dynamic member lookup
  • Issue: rdar://164321858
  • Risk: Low, the change is isolated to the key path dynamic member lookup logic and the fix itself is only re-ordering the introduction of constraints, which better matches what we do in CSGen
  • Testing: Added tests to test suite
  • Reviewer: Slava Pestov

Otherwise if the member lookup gets simplified immediately and we 
have a recursive dynamic member lookup we will crash since we wouldn't
have introduced the corresponding applicable function constraint.

rdar://164321858
@hamishknight hamishknight requested a review from hborla December 12, 2025 17:14
@hamishknight hamishknight requested a review from a team as a code owner December 12, 2025 17:14
@hamishknight hamishknight added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.3 labels Dec 12, 2025
@hamishknight
Copy link
Contributor Author

@swift-ci please test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍒 release cherry pick Flag: Release branch cherry picks swift 6.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants