[cxx-interop] Import operators renamed via swift_name consistently
#86004
+46
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally Swift imports `T& operator*` as `var pointee: T`. However, when the C++ operator has `swift_name` attribute attached to it, the importing was inconsistent: the renamed function was marked as deprecated, and an additional undesired overload was created. For instance: ``` const std::string& operator*() const SWIFT_NAME(dereference()); ``` was imported as an unavailable/deprecated `func dereference()`, and an additional overload of `func *(_:)` was created. rdar://163500978
egorzhdan
requested review from
beccadax,
hnrklssn,
ian-twilightcoder and
susmonteiro
as code owners
Contributor
Author
|
@swift-ci please smoke test |
Xazax-hun
approved these changes
Dec 12, 2025
susmonteiro
approved these changes
Dec 12, 2025
Contributor
Author
|
@swift-ci please smoke test macOS |
j-hui
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally Swift imports
T& operator*asvar pointee: T. However, when the C++ operator hasswift_nameattribute attached to it, the importing was inconsistent: the renamed function was marked as deprecated, and an additional undesired overload was created.For instance:
was imported as an unavailable/deprecated
func dereference(), and an additional overload offunc *(_:)was created.rdar://163500978