Isolated keyword should not be permitted in inheritance clause #86001
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexsanderDamaceno
requested review from
AnthonyLatsis,
hborla,
ktoso,
slavapestov and
xedin
as code owners
jamieQ
reviewed
Dec 12, 2025
lib/Sema/TypeCheckType.cpp
Outdated
| NeverNullType | ||
| TypeResolver::resolveIsolatedTypeRepr(IsolatedTypeRepr *repr, | ||
| TypeResolutionOptions options) { | ||
| // isolated is only value for non-EnumCaseDecl parameters. |
Contributor
There was a problem hiding this comment.
nit: maybe fix the typo in this comment while in here
Suggested change
| // isolated is only value for non-EnumCaseDecl parameters. | |
| // isolated is only valid for non-EnumCaseDecl parameters. |
| (options.hasBase(TypeResolverContext::EnumElementDecl) && | ||
| !options.is(TypeResolverContext::Inherited)) || options.is(TypeResolverContext::Inherited))) { | ||
| diagnoseInvalid( | ||
| repr, repr->getSpecifierLoc(), diag::attr_only_on_parameters, |
Contributor
There was a problem hiding this comment.
aside: this diagnostic no longer seems accurate since isolated is now valid on deinits.
Author
There was a problem hiding this comment.
Ok, will do a pr removing this
| options.hasBase(TypeResolverContext::EnumElementDecl)) && | ||
| !options.is(TypeResolverContext::Inherited)) { | ||
| (options.hasBase(TypeResolverContext::EnumElementDecl) && | ||
| !options.is(TypeResolverContext::Inherited)) || options.is(TypeResolverContext::Inherited))) { |
Contributor
Author
There was a problem hiding this comment.
it looks that this changes are related to related to use isolated in actors
| } | ||
|
|
||
| protocol P {} | ||
| struct S: isolated P {} // expected-error {{'isolated' may only be used on parameters}} |
Contributor
There was a problem hiding this comment.
nit: the referenced 'enum decl' case should probably also have a test (i didn't see any when searching for this error message).
edit: when testing it out, seems this will just crash the compiler:
enum E {
case iso(isolated any Actor)
}but i guess that's a separate bug i will file filed: #86007
AlexsanderDamaceno
force-pushed
the
isolated_fix_inheritance
branch
from
c327081 to
c73dff8
Compare
Author
|
@xedin hey, could take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in #83538, Isolated keyword should not be permitted in inheritance clause