[SILOpt] Don't apply @_specialize attribute to ObjC methods
#85989
+82
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci smoke test |
Kyle-Ye
reviewed
Dec 12, 2025
Contributor
Kyle-Ye
left a comment
Kyle-Ye
left a comment
There was a problem hiding this comment.
I assume the commit message and PR title should use “attribute” instead of “aatribute”? It looks like to a typo for me.
Contributor
Author
Yes, thanks! |
rdar://164200332 The specialization should only apply to the Swift version of the method, which gets called by the ObjC version anyway, so the specialization is still in effect.
drexin
force-pushed
the
wip-164200332
branch
from
3d86606 to
6f0f9db
Compare
drexin
changed the title
@_specialize aatribute to ObjC methods@_specialize attribute to ObjC methods
Contributor
Author
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://164200332
The specialization should only apply to the Swift version of the method, which gets called by the ObjC version anyway, so the specialization is still in effect.