Address review comments on JSONRPCConnection update
#29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
requested review from
ahoppen,
hamishknight,
owenv and
rintaro
as code owners
bnbarham
force-pushed
the
rpc-review-comments
branch
from
bd99cb0 to
5acb90d
Compare
ahoppen
approved these changes
Dec 8, 2025
Sources/LanguageServerProtocolTransport/JSONRPCConnection.swift
Outdated
Show resolved
Hide resolved
Sources/LanguageServerProtocolTransport/JSONRPCConnection.swift
Outdated
Show resolved
Hide resolved
1. Rename `readQueue` to `receiveQueue` to match `receiveFD` 2. Add `name` into all queues (helps debugging in tests, which often have two connections in a single process) 3. Close mirror file handles 4. Rename the `send` that assumes it is on queue to `sendAssumingOnQueue` 5. Move all `DispatchData` to `Data` 6. Read multiple bytes at a time during the header phase
bnbarham
force-pushed
the
rpc-review-comments
branch
from
5acb90d to
9300396
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readQueuetoreceiveQueueto matchreceiveFDnameinto all queues (helps debugging in tests, which often have two connections in a single process)sendthat assumes it is on queue tosendAssumingOnQueueDispatchDatatoData