[6.2] Fix up AttributeTypeSyntax handling #1124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a few issues here: 1. Type specifiers can now have arguments (eg. `nonisolated(nonsending)`) 2. Some type specifiers can be specified "late", which are currently unhandled 3. We were using a mix of `.same` and `.continue` breaks (`.continue` for specifiers and `.same` for attributes) 4. Attributes were grouped separately to specifiers Fixes swiftlang#1081 (cherry picked from commit b2091bd)
Causes quite a few changes in eg. sourcekit-lsp, so presumably will in other codebases as well. Ideally we'd add this behind some new versioning in the config. As an example of a change this causes: ``` private let logMessageToIndexLog: @sendable ( _ message: String, _ type: WindowMessageType, _ structure: LanguageServerProtocol.StructuredLogKind ) -> Void ``` To: ``` @sendable ( _ message: String, _ type: WindowMessageType, _ structure: LanguageServerProtocol.StructuredLogKind ) -> Void ``` (cherry picked from commit d022b8b)
Member
Author
|
@swift-ci Please test |
hborla
approved these changes
Dec 16, 2025
Now that workflows is a more stable, use the most recent tag instead of main to avoid changes to default jobs preventing merging. (cherry picked from commit 58125eb)
Exclude `"5.9"` from `windows_swift_versions` until swiftlang#1094 is resolved on swift-markdown's side (cherry picked from commit 2c59487)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #1086 and #1088 into
release/6.2nonisolated(nonsending)) weren't correctly formatted because there're not handled.