Skip to content

[lldb][windows] add NSDate and FoundationEssentials.Date dataformatters #11948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adrian-prantl merged 1 commit into from
Dec 12, 2025
Merged

[lldb][windows] add NSDate and FoundationEssentials.Date dataformatters #11948

adrian-prantl merged 1 commit into from
Dec 12, 2025
+70 −3

Conversation

@charles-zablit
Copy link

@charles-zablit charles-zablit commented Dec 5, 2025 •
edited
Loading

This patch adds a dataformatter for FoundationEssentials.Date and NSDate on Windows.

Before

1> Date.now
$R1: FoundationEssentials.Date = {
  _time = 786641176.638381
}
2> NSDate()
$R2: Foundation.NSDate = {
  Foundation.NSObject = {}
  _base = {
    info = 10880
    pad = 0
  }
  _timeIntervalSinceReferenceDate = 786641176.638381
}

After

1> Date.now
$R1: Foundation.Date = 2025-12-05 15:26:16 UTC
2> NSDate()
$R2: NSDate = 2025-12-05 15:26:16 UTC

rdar://155901731

@charles-zablit charles-zablit requested a review from a team as a code owner December 5, 2025 15:27
@charles-zablit charles-zablit self-assigned this Dec 5, 2025
@charles-zablit
Copy link
Author

charles-zablit commented Dec 5, 2025

@swift-ci please test

@charles-zablit charles-zablit force-pushed the charles-zablit/lldb/windows/add-date-dataformatter branch from b5c7671 to 3a44d26 Compare December 5, 2025 16:38
@charles-zablit charles-zablit marked this pull request as draft December 5, 2025 16:38
@charles-zablit
Copy link
Author

charles-zablit commented Dec 5, 2025

@swift-ci please test

1 similar comment
@charles-zablit
Copy link
Author

charles-zablit commented Dec 5, 2025

@swift-ci please test

@charles-zablit
Copy link
Author

charles-zablit commented Dec 8, 2025

@swift-ci please test linux

@charles-zablit
Copy link
Author

charles-zablit commented Dec 8, 2025

@swift-ci please test windows

@charles-zablit charles-zablit force-pushed the charles-zablit/lldb/windows/add-date-dataformatter branch from 3a44d26 to 1950598 Compare December 9, 2025 15:31
@charles-zablit
Copy link
Author

charles-zablit commented Dec 9, 2025

@swift-ci please test

@charles-zablit charles-zablit marked this pull request as ready for review December 9, 2025 15:32
@charles-zablit charles-zablit force-pushed the charles-zablit/lldb/windows/add-date-dataformatter branch from 1950598 to 03c590b Compare December 9, 2025 15:40
@charles-zablit
Copy link
Author

charles-zablit commented Dec 9, 2025

@swift-ci please test

@charles-zablit charles-zablit force-pushed the charles-zablit/lldb/windows/add-date-dataformatter branch from 03c590b to d84204e Compare December 9, 2025 17:43
@charles-zablit
Copy link
Author

charles-zablit commented Dec 9, 2025

@swift-ci please test

adrian-prantl
adrian-prantl reviewed Dec 9, 2025
View reviewed changes
lldb/source/Plugins/Language/Swift/FoundationValueTypes.cpp Outdated
if (!time_sp)
time_sp = valobj.GetChildAtNamePath(
{g__timeIntervalSinceReferenceDate, "_value"});
#endif
Copy link

@adrian-prantl adrian-prantl Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably not correct. The #idef checks of a property of the platform lldb is running on, but you probably want to do something different based on the target triple. I.e., this should not trigger if you debug a macOS process over the network with lldb.exe.

Copy link
Author

@charles-zablit charles-zablit Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed this by removing the #ifdef check. The GetChildAtNamePath call will only succeed on Windows anyways.

felipepiovezan
felipepiovezan reviewed Dec 10, 2025
View reviewed changes
lldb/source/Plugins/Language/ObjC/Cocoa.cpp
tm_epoch.tm_sec = 0;
tm_epoch.tm_hour = 0;
tm_epoch.tm_min = 0;
tm_epoch.tm_mon = 0;
Copy link

@felipepiovezan felipepiovezan Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: is this diff relevant for the pr?

Copy link
Author

@charles-zablit charles-zablit Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No really, I reverted it 👍

@charles-zablit charles-zablit force-pushed the charles-zablit/lldb/windows/add-date-dataformatter branch 2 times, most recently from 0e4153a to 4c57eed Compare December 10, 2025 16:29
@charles-zablit
Copy link
Author

charles-zablit commented Dec 10, 2025

@swift-ci please test

@charles-zablit charles-zablit force-pushed the charles-zablit/lldb/windows/add-date-dataformatter branch from 4c57eed to 0eb0338 Compare December 10, 2025 16:35
charles-zablit
charles-zablit commented Dec 10, 2025
View reviewed changes
lldb/source/Plugins/Language/Swift/SwiftLanguage.cpp
"Foundation.Date summary provider", ConstString("Foundation.Date"),
TypeSummaryImpl::Flags(summary_flags).SetDontShowChildren(true));
"Foundation.Date summary provider",
ConstString("Foundation(Essentials)?\\.(NS)?Date"),
Copy link
Author

@charles-zablit charles-zablit Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will match:

  • Foundation.Date
  • FoundationEssentials.Date
  • Foundation.NSDate

This should not clash with the other Foundation.NSDate formatter. The tests should confirm this.

@charles-zablit
Copy link
Author

charles-zablit commented Dec 10, 2025

@swift-ci please test

@charles-zablit
Copy link
Author

charles-zablit commented Dec 11, 2025

@swift-ci please test macos

@adrian-prantl adrian-prantl merged commit 9f6bc46 into swiftlang:swift/release/6.3 Dec 12, 2025
3 checks passed
augusto2112
augusto2112 reviewed Dec 15, 2025
View reviewed changes
lldb/test/API/functionalities/data-formatter/swift/date/TestSwiftDateFormatters.py
)

self.expect(
"v date",
Copy link

@augusto2112 augusto2112 Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit (for the future): I think it's better to spell out "frame variable" instead of "v". We've changed aliases in the past so it could happen again, it's also easier to grep

Copy link
Author

@charles-zablit charles-zablit Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I opened #12005 as a follow up.

lldb/test/API/functionalities/data-formatter/swift/date/main.swift
@@ -0,0 +1,16 @@
import Foundation

let paris = TimeZone(identifier: "Europe/Paris")!
Copy link

@augusto2112 augusto2112 Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: it would be better to put this code in a main() (or whatever name you want) function and immediately call it. These variables are actually static, not local variables. I think this works now because of DIL but we might want to go back to enforcing frame var works only for local variables in the future.

Copy link
Author

@charles-zablit charles-zablit Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I opened #12005 as a follow up.

@charles-zablit charles-zablit mentioned this pull request Dec 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@augusto2112 augusto2112 augusto2112 left review comments

@felipepiovezan felipepiovezan felipepiovezan left review comments

@adrian-prantl adrian-prantl adrian-prantl approved these changes

@Michael137 Michael137 Awaiting requested review from Michael137

Assignees

@charles-zablit charles-zablit

Labels

LLDB for Swift Windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@charles-zablit @adrian-prantl @augusto2112 @felipepiovezan