Support for anonymous repeated wildcards in pattern syntax. #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
copybara_568276609
branch
3 times, most recently
from
105934a to
0236ee2
Compare
(Non-anonymous repeated are syntactically allowed, for completeness, but discarded unless the name is `_`.)
This is a rough first pass, with several obvious gotchas:
1) Since it uses globs, it depends on where a list occurs in the AST. For instance, dicts, which have a _separate_ list of keys and values, can get spurious matches: `{$...:$..., k1: v2, $...:$...}` will match the dict `{k1: v1, k2: v2}`.
That said, it does still let one sensibly write `{$... : $...}`, which is more than we can say for function calls!
2) In the reverse of (1), if something is not a list, the glob doesn't apply there. For instance, one cannot currently use the pattern `foo($...=$...)` at all, because unlike dicts, they use a single list of `keyword()` nodes.
So followup CLs need to add special handling of repeated wildcards in specific places in the AST. In particular, a rough TODO list looks like:
1) Either reject, or tie up the globs, for dicts.
2) special-case the glob syntax in kwargs
3) Special-case a glob that occurs in `*` or `**` to also catch those. `foo(*$..., **$...)` should catch every call to `foo` with any args.
PiperOrigin-RevId: 568276609
copybara-service
bot
force-pushed
the
copybara_568276609
branch
from
0236ee2 to
5f9be63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for anonymous repeated wildcards in pattern syntax.
(Non-anonymous repeated are syntactically allowed, for completeness, but discarded unless the name is
_.)This is a rough first pass, with several obvious gotchas:
Since it uses globs, it depends on where a list occurs in the AST. For instance, dicts, which have a separate list of keys and values, can get spurious matches:
{$...:$..., k1: v2, $...:$...}will match the dict{k1: v1, k2: v2}.That said, it does still let one sensibly write
{$... : $...}, which is more than we can say for function calls!In the reverse of (1), if something is not a list, the glob doesn't apply there. For instance, one cannot currently use the pattern
foo($...=$...)at all, because unlike dicts, they use a single list ofkeyword()nodes.So followup CLs need to add special handling of repeated wildcards in specific places in the AST. In particular, a rough TODO list looks like:
*or**to also catch those.foo(*$..., **$...)should catch every call tofoowith any args.