Upgrade abstract flow execution tests from JUnit 4 to JUnit 6 #1838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Charmant <jon.charmant@bristol.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the execution of a XML-based flow definition is achieved by extending AbstractXmlFlowExecutionTests. This class is a subclass of JUnit4 TestCase.
It might be preferable for this class and related classes in the org.springframework.webflow.test.execution package to run JUnit 6 tests and this PR upgrades the abstract classes in org.springframework.webflow.test.execution to use JUnit 6 and removes JUnit 4 dependency entirely from the configuration.
This will be a breaking change for anyone who currently extends AbstractXmlFlowExecutionTests to test their XML configuration.