Skip to content

Conversation

@sri1873
Copy link
Contributor

@sri1873 sri1873 commented Dec 4, 2025

Changes Made for #1984

  1. Put GroupId and artifactId into a single div.
  2. Reduced padding from 0.6rem to 0.45rem to fit them on one screen.
image

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 4, 2025
@mhalbritter mhalbritter self-assigned this Dec 5, 2025
@mhalbritter
Copy link
Contributor

mhalbritter commented Dec 5, 2025

Thanks for the PR - this looks okay-ish on smaller screens, but on my screen in full screen it looks like this:

image

There's a lot of "wasted" space after the "Artifact" textbox, and before the "Artifact" label. Adjusting the padding of all "control" classes also alters the whole layout, not only for the two text fields which are now next to each other.

I also think the spacing between "Group" and "Name" is bigger than the spacing between "Name" and "Description".

@mhalbritter mhalbritter added the status: waiting-for-feedback We need additional information before we can continue label Dec 5, 2025
@sri1873 sri1873 marked this pull request as draft December 5, 2025 15:09
@sri1873
Copy link
Contributor Author

sri1873 commented Dec 5, 2025

image

New Changes

  1. Reverted "control" classes padding to the original.
  2. Adjusted the width of text input fields to maintain alignment, as well as use up space

Between 1000px and 1200px, the input fields of "Group" and "Artifact" become too small, to avoid that, in those screen sizes the fields will go back to occupying the entire row.

Please let me know if something else needs to be changed

@sri1873 sri1873 marked this pull request as ready for review December 5, 2025 22:20
@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Dec 5, 2025
Signed-off-by: Sri Kumar <kssrikumar180703@gmail.com>
@mhalbritter mhalbritter changed the title Website has to be scrolled vertically on smaller screens - for #1984 Website has to be scrolled vertically on smaller screens Dec 15, 2025
@mhalbritter mhalbritter added type: enhancement and removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided labels Dec 15, 2025
mhalbritter pushed a commit that referenced this pull request Dec 15, 2025
See gh-2010

Signed-off-by: Sri Kumar <kssrikumar180703@gmail.com>
mhalbritter added a commit that referenced this pull request Dec 15, 2025
@mhalbritter
Copy link
Contributor

Thanks @sri1873 !

@mhalbritter
Copy link
Contributor

mhalbritter commented Dec 15, 2025

I made a smaller change to get rid of the nth-child(2) selector by adding an explicit class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants