make sure stream exists before flushing #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
330
to
332
| if stream = @stream | ||
| if @stream | ||
| @stream.close | ||
| @stream = nil | ||
| stream.close |
Contributor
There was a problem hiding this comment.
The pattern here is deliberate to set @stream to nil before calling #close which may, in theory, be a schedule point.
| # Write a message to the connection stream. | ||
| # | ||
| # @parameter message [Hash] The message to write. | ||
| def write(**message) |
Contributor
There was a problem hiding this comment.
If we are going to do this, I think it's better that we are explicit rather than just silently failing the write, e.g. raise IOError
Suggested change
| def write(**message) | |
| def write(**message) | |
| raise IOError, "Connection closed!" if @stream.nil? |
Contributor
There was a problem hiding this comment.
(Then, we should probably have the caller deal with this exception gracefully).
Contributor
Author
There was a problem hiding this comment.
yup - good idea 👍
It looks like Connection#call and Connection#dispatch already gracefully handles the IOError
samuel-williams-shopify
force-pushed
the
fix-safe-connection-flush
branch
from
98277d3 to
a550afe
Compare
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for
@streamto benilduring@stream.write.Types of Changes
Contribution