Skip to content
This repository was archived by the owner on Jan 17, 2022. It is now read-only.

Conversation

@cvogt
Copy link
Member

@cvogt cvogt commented Aug 23, 2013

review by @szeiger

@szeiger
Copy link
Member

szeiger commented Aug 27, 2013

I'd rather apply sortBy calls for the individual keys in reverse order so you don't have to construct internal objects like Ordered manually and step outside of the type-safe lifted embedding API.

@cvogt
Copy link
Member Author

cvogt commented Aug 27, 2013

@szeiger: I agree, updated the commit to do that

@cvogt
Copy link
Member Author

cvogt commented Aug 30, 2013

@szeiger Please have a look. I'd like to answer some ML / SO postings with this.

@szeiger
Copy link
Member

szeiger commented Nov 27, 2013

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants