-
Notifications
You must be signed in to change notification settings - Fork 4
feat: add dkg result injection script #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: shutter-api
Are you sure you want to change the base?
Conversation
| exit 1 | ||
| fi | ||
|
|
||
| if ! [[ "$MIN_TENDERMINT_CURRENT_BLOCK" =~ ^-?[0-9]+$ ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check should be before we start fetching current tendermint block
|
|
||
| log "Checking shuttermint sync block number >= ${MIN_TENDERMINT_CURRENT_BLOCK}" | ||
| CURRENT_BLOCK=$(docker compose exec -T db sh -lc \ | ||
| "psql -t -A -U postgres -d ${KEYPER_DB} -c \"SELECT current_block FROM tendermint_sync_meta LIMIT 1\"" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here we should have a ORDER BY current_block DESC clause to fetch the latest synced tendermint block
|
|
||
| EON="1" | ||
| KEYPER_CONFIG_INDEX="1" | ||
| MIN_TENDERMINT_CURRENT_BLOCK="0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this value be updated? or we want the keyper to sync only to block zero?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the parametesr EON, KEYPER_CONFIG_INDEX and MIN_TENDERMINT_CURRENT_BLOCK still need to be updated for the particular deployment.
| SELECT_COLUMN_LIST+=("$col") | ||
| done | ||
|
|
||
| if [[ "${#SELECT_COLUMN_LIST[@]}" -eq 0 ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit pick: not necessary check as the SELECT_COLUMN_LIST gets generated from TABLES array anyway, which is already defined in the script itself
blockchainluffy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no info on how are we planning to release this script? also what should be the params while running the script? Can you please add that info for some more context?
No description provided.