-
Notifications
You must be signed in to change notification settings - Fork 204
SG-41463 Improve CI Pipeline by re-using tk-ci-tools and build Sphinx documentation #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the CI pipeline to leverage the shared tk-ci-tools repository instead of maintaining duplicate CI code locally. The main objective is to improve maintainability by reusing common CI tooling and adding Sphinx documentation builds.
Key Changes:
- Replaced local code style validation with the shared
build-pipeline.ymltemplate fromtk-ci-tools - Added resource repository configuration to reference
tk-ci-toolsfor shared CI templates - Removed the local
code_style_validation.ymltemplate file
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| azure-pipelines.yml | Added tk-ci-tools repository resource and replaced local template with shared build-pipeline template |
| azure-pipelines-templates/code_style_validation.yml | Deleted local code style validation template as it's now handled by tk-ci-tools |
| shotgun_api3/shotgun.py | Added blank line in docstring for formatting consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Improve CI by calling tk-ci-tools instead of doing it in house.
Why?
PR Merge Order