Revert "Add more functionality to LLFile and cleanup LLAPRFile" #5142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c894a74.
…recommended by Copilot" This reverts commit 88b6765.
…set value. Improve error checking inside function and add comment about not updating the seek pointer when an offset of 0 is specified" This reverts commit 4153d67.
This reverts commit 9aff5ff.
This reverts commit 71721b8.
This reverts commit 2c8f8fd.
…pr.h as it was not neededanywhere else" This reverts commit 23a3cdd.
…a file" This reverts commit 0fed0bf.
This reverts commit c2898f7.
This reverts commit 8edaa00.
…ilot and make LLFile::size() return -1 on error and adjust the callers to account for that." This reverts commit 2438854.
This reverts commit e0c5fc8.
This reverts commit fe61aa3.
…tire paths" This reverts commit 15f9886.
…rove error handling in LLFile::read(), LLFile::write() and LLFile::copy() - Improve LLFileSystem::getFileSize() to work with the extra possibility of LLFile::size() returning -1 on error - Replace LLAPRFile:readEx() and LLAPRFile::writeEx() with according LLFile functions" This reverts commit 13a3cf9.
This reverts commit 62e08e1.
This reverts commit f07762a.
…e::write() static function. These functions will be used to replace LLAPRFile::readEx() and LLAPRFile::writeEx() in an upcoming patch." This reverts commit 9756b4b.
…e of a file_name. Replace LLAPRFile::remove(), LLAPRFile::size() and LLAPRFile::isExist() with according functions from LLFile and retire these LLAPRFile methods and the never used LLAPRFile::rename(), LLAPRFile::makeDir() and LLAPRFile::removeDir() functions. Also clean up remarks about the threading safety of the APRCachePool, which is not used in these locations anymore." This reverts commit 3ca3ea7.
github-actions
bot
added
c/cpp
cmake
llcommon
llcrashlogger
llfilesystem
llmessage
llrender
llaudio
llxml
labels
Geenz
approved these changes
Dec 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4899
Interferes with linux work, will be moved to a different branch and applied separately.