Work for new caution permission. #5093
Conversation
…n multiple messages.
#4628 New land access permission
There was a problem hiding this comment.
Pull request overview
This PR adds support for a new "privileged land access" script permission that allows objects to sell land on behalf of users. The change coordinates with a server-side update to handle this new permission type with appropriate caution dialogs.
- Adds
PrivilegedLandAccessas a new cautioned permission (19th permission) - Refactors caution dialog to support multiple warning messages instead of hardcoded single message
- Updates UI layout to dynamically adjust based on visible content
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| indra/newview/llscriptruntimeperms.h | Adds new PrivilegedLandAccess permission bit and updates array type from boost to std |
| indra/newview/llviewermessage.cpp | Refactors caution handling to build dynamic warning messages for multiple caution permissions |
| indra/newview/lltoastscriptquestion.cpp | Improves layout calculation to handle optional footer visibility and dynamic content sizing |
| indra/newview/skins/default/xui/en/strings.xml | Adds localized strings for the new land permission caution and description |
| indra/newview/skins/default/xui/en/notifications.xml | Updates notification template to accept dynamic warning content |
| indra/newview/skins/default/xui/en/panel_script_question_toast.xml | Adjusts panel height and footer behavior for dynamic sizing |
| indra/newview/llviewerwindow.cpp | Removes unused boost/lambda header |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // Caustions go into top part of the dialog, questions go into the footer | ||
| if (caution_enabled && script_perm.caution) | ||
| { | ||
| warning_msg += "\n" + LLTrans::getString(script_perm.question + "Caution") + "\n"; |
There was a problem hiding this comment.
The warning message construction adds leading and trailing newlines for each caution, which may result in excessive whitespace. Consider building the message without trailing newlines and adding them only between items, or trim the final result.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Issue #4628
Handle new privileged land permission. Allow caution dialog to contain multiple messages, (Debt and Land)
This is the viewer side for https://github.com/secondlife/server/pull/2249.
Supports the new permission and correctly handles multiple possible warning conditions.