Inherit package configuration (version and description) from workspace root

[MarijnS95]

Depends on #83

Starting with Rust 1.64 common [package] parameters (and dependencies) can now be specified in the workspace root manifest by setting <field>.workspace=true in a [package] and specifying its value in the workspace root manifest under [workspace.package].

Since xbuild reads the version and description field from [package] it has to support this new format and pull the values from the root manifest instead, in order to support projects utilizing this new format.

This is currently implemented ad-hoc for the version and description field, but could be done in a cleaner way if/when more fields are needed.

[MarijnS95]

warning: clang: error while loading shared libraries: libtinfo.so.5: cannot open shared object file: No such file or directory

It looks like this failed CI run (https://github.com/rust-mobile/xbuild/actions/runs/3631870305/jobs/6127317944) uses Ubuntu 22.04 where there's no ncurses5 anymore. A successful run from yesterday was still using 20.04: https://github.com/rust-mobile/xbuild/actions/runs/3628115674/jobs/6118758852

On Arch I have an ncurses5-compat-libs package to provide ncurses5 next to ncurses 6, let's see if there's something like that for Ubuntu or if we should reconfigure our build to not use ncurses5?

EDIT: It looks to be the clang/llvm 13 release that is still linking against and requiring ncurses5...

[MarijnS95]

Seems to be working on LLVM 14: https://github.com/MarijnS95/xbuild/actions/runs/3637588613

But @dvc94ch maybe we shouldn't use a dioxus git repo without rev, they broke master:

https://github.com/DioxusLabs/dioxus/pull/600/files#diff-b301b62a0211c4c1ac30c6ba1bb560fb21729654867dbcfbed0876529e26cae1R284

EDIT: Reported at DioxusLabs/dioxus#600 (review)

[dvc94ch]

so this one is ready to rebase/merge?

out of curiosity, do you know a good cross platform crate to get the platform specific config directory? looks like none of them work on android

[MarijnS95]

Yes, thanks for fixing the CI!

out of curiosity, do you know a good cross platform crate to get the platform specific config directory? looks like none of them work on android

What do you mean, a file path on the device? I don't think a "config" folder exists per-se, it's all a pretty generic /files where everything gets dumped into.

[dvc94ch]

fixed it here: xdg-rs/dirs#63

[MarijnS95]

Oh you mean that (not really a config dir for android still, just a per-app consistent storage place like appdata and .config or .local). I've been using and maintaining https://crates.io/crates/app_dirs2 here. dirs seems unmaintained, and app_dirs was unmaintained too :(

[dvc94ch]

maybe a good candidate for the rust-mobile org? can we merge this PR?

[MarijnS95]

maybe a good candidate for the rust-mobile org?

It also handles other platforms in a somewhat-generic way, don't think it fits but you'd have to ask the author otherwise.

can we merge this PR?

Yes please! I was waiting for the CI to succeed and the new branch protection settings require at least one explicit approval (which I don't fancy bypassing).