refactor: improve environment diffing using BTreeSet #2188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace HashSet with BTreeSet for deterministic ordering - Simplify diff_environments logic using set operations directly - Simplify EnvironmentDiff enum by using tuple variants - Remove unused patterns_equal function - Update test snapshots to match new enum structure This refactoring makes the environment diffing code cleaner and more maintainable while ensuring consistent output ordering.
amustaque97
requested review from
Mark-Simulacrum,
jdno,
marcoieni and
pietroalbini
as code owners
Dry-run check results |
Kobzol
reviewed
Dec 16, 2025
| remove_branches: Vec<String>, | ||
| add_tags: Vec<String>, | ||
| remove_tags: Vec<String>, | ||
| new_branches: Vec<String>, |
Member
There was a problem hiding this comment.
I think that it would be better if the sync code directly operated on branches/tags to add or remove, rather than having generic code that then tries to load the current state from GitHub again when doing the sync.
In other words, I would remove new_branches and new_tags, and keep only add/remove.
Member
There was a problem hiding this comment.
I approved this PR because it's an improvement with respect to the previous code.
This improvement can be done in another PR 👍
marcoieni
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Separate PR is asked in one of the comments #2168 (comment), and it makes sense. This is done as part of refactoring existing code; there are no functionality changes.
cc @marcoieni