-
Notifications
You must be signed in to change notification settings - Fork 164
Toggle status page date format between 24hr and 12hr #2354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Kobzol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Left some comments.
|
🤦 I thought that this all sounded a bit too familiar, and now I know why. I already implemented a general system for storing things into localstorage and turning them into Vue refs some time ago, but I forgot about it 😆 I modified your PR to use this existing system, hope you don't mind. |
fcac640 to
d44b23e
Compare
d44b23e to
2574e33
Compare
Looks good to me 👍 |
Kobzol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
A little checkbox button allowing changing the date format between 24hr and 12hr;
24hr
12hr
Closes #2347