Downgrade curl-sys to 0.4.83 #16379

asomers · 2025-12-11T15:53:10Z

With version 0.4.84, cargo was failing on FreeBSD 13.5 and 14.3 every time, with errors like this:

    Updating crates.io index
error: failed to get `futures` as a dependency of package `tokio-file v0.11.0 (/tmp/cirrus-ci-build)`
Caused by:
  download of config.json failed
Caused by:
  failed to download from `https://index.crates.io/config.json`
Caused by:
  [60] SSL peer certificate or SSH remote key was not OK (SSL certificate OpenSSL verify result: unable to get local issuer certificate (20))

Fixes #16357

Thanks for the pull request 🎉!
Please read the contribution guide: https://doc.crates.io/contrib/.

What does this PR try to resolve?

Explain the motivation behind this change.
A clear overview along with an in-depth explanation are helpful.

How to test and review this PR?

Demonstrate how you test this change and guide reviewers through your PR.
With a smooth review process, a pull request usually gets reviewed quicker.

rustbot · 2025-12-11T15:53:16Z

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

weihanglo · 2025-12-11T17:25:23Z

Cargo.toml

 criterion = { version = "0.7.0", features = ["html_reports"] }
 curl = "0.4.49"
-curl-sys = "0.4.84"
+curl-sys = "=0.4.83"


We usually don't put exact requirement in Cargo.toml for libcargo. It may potentially cause dependency resolution problem to libcargo consumers.

Instead, we leave it as caret requirement, add a comment to track it, and ignore auto-dep update for that.

chore: downgrade to libc@0.2.174 #15918

399f2c7

9c4007c

weihanglo · 2025-12-11T17:35:28Z

Cargo.toml

 criterion = { version = "0.7.0", features = ["html_reports"] }
 curl = "0.4.49"
-curl-sys = "0.4.84"
+curl-sys = "0.4.83"


A comment in Cargo.toml would also help avoid accidental updates.

weihanglo

Thanks.

View changes since this review

weihanglo · 2025-12-11T17:53:04Z

You might need to rebase onto master to fix the CI failure.

(And personally I feel like we can squash those commits into one?)

asomers · 2025-12-11T18:02:45Z

Hmm. This PR is already at the latest master. Do I need to wait for #16380 to land?

weihanglo · 2025-12-11T18:08:56Z

Yeah it just landed.

With version 0.4.84, cargo was failing on FreeBSD 13.5 and 14.3 every time, with errors like this: ``` Updating crates.io index error: failed to get `futures` as a dependency of package `tokio-file v0.11.0 (/tmp/cirrus-ci-build)` Caused by: download of config.json failed Caused by: failed to download from `https://index.crates.io/config.json` Caused by: [60] SSL peer certificate or SSH remote key was not OK (SSL certificate OpenSSL verify result: unable to get local issuer certificate (20)) ``` Fixes rust-lang#16357

rustbot · 2025-12-11T18:13:10Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

asomers · 2025-12-11T18:13:17Z

Squashed and rebased.

ehuss · 2025-12-12T13:51:38Z

Is there something tracking to update this? Is it known what the issue is? I would prefer to not keep this downgraded for an extended period of time.

weihanglo · 2025-12-12T14:07:54Z

Ah. I thought the original issue wasn't closed. Reopening.

Update cargo submodule 27 commits in 2c283a9a5c5968eeb9a8f12313f04feb1ff8dfac..c46423de7351e3c4c734b2faa86088a9f5d1302b 2025-12-04 16:47:28 +0000 to 2025-12-12 23:16:12 +0000 - feat(report): cargo report timings HTML replay (rust-lang/cargo#16377) - feat: stabilize `-Zconfig-include` (rust-lang/cargo#16284) - fix(package): Don't verify registry for --list (rust-lang/cargo#16341) - Fixed incorrect locking logic when artifact-dir == build-dir (rust-lang/cargo#16385) - feat(log): make timing messages ready for HTML replay (rust-lang/cargo#16382) - chore(deps): update msrv (1 version) to v1.92 (rust-lang/cargo#16381) - Downgrade curl-sys to 0.4.83 (rust-lang/cargo#16379) - fix(timing): more self-contained timing/log data (rust-lang/cargo#16378) - test: update to `proc_macro::tracked::path` (rust-lang/cargo#16380) - refactor(lint): move lints to separate modules (rust-lang/cargo#16364) - fix(index): Apply feedback from Cargo team (rust-lang/cargo#16369) - fix(lints): handle lints separately at ws pkg level (rust-lang/cargo#16367) - feat(lint): new `implicit_minimum_version_req` lint (rust-lang/cargo#16321) - fix(info): default to local without explicit reg (rust-lang/cargo#16358) - Remove `[no-mentions]` handler in our triagebot config (rust-lang/cargo#16361) - Don't read the config file twice when $CARGO_HOME is a symlink (rust-lang/cargo#16325) - fix(timings): forgot to negate filter (rust-lang/cargo#16352) - fix(doctest): Include all search paths with new build layout (rust-lang/cargo#16348) - fix(layout): Remove hashes from bins in new layout (rust-lang/cargo#16351) - docs(faq): Include an entry on disk space (rust-lang/cargo#16349) - feat(timings): derive concurrency data from unit data (rust-lang/cargo#16350) - perf(layout): Use unit_id, not pkg hash, for bin/lib pkg_dirs for new layout (rust-lang/cargo#16345) - Validate target source paths before compilation with clearer errors (rust-lang/cargo#16338) - test(doc): Remove unused build script (rust-lang/cargo#16344) - refactor(timings): store UnitData in RenderContext instead (rust-lang/cargo#16346) - perf(clean): Optimize (legacy) clean with multiple -p specifiers (rust-lang/cargo#16264) - test: Adjust output for out-of-tree build-dir (rust-lang/cargo#16343)

Update cargo submodule 29 commits in 2c283a9a5c5968eeb9a8f12313f04feb1ff8dfac..e91b2baa632c0c7e84216c91ecfe107c37d887c1 2025-12-04 16:47:28 +0000 to 2025-12-13 16:29:21 +0000 - refactor(lints): move from cargo::util::lints to cargo::lints (rust-lang/cargo#16392) - test(lint): redact more due to line got omitted (rust-lang/cargo#16391) - feat(report): cargo report timings HTML replay (rust-lang/cargo#16377) - feat: stabilize `-Zconfig-include` (rust-lang/cargo#16284) - fix(package): Don't verify registry for --list (rust-lang/cargo#16341) - Fixed incorrect locking logic when artifact-dir == build-dir (rust-lang/cargo#16385) - feat(log): make timing messages ready for HTML replay (rust-lang/cargo#16382) - chore(deps): update msrv (1 version) to v1.92 (rust-lang/cargo#16381) - Downgrade curl-sys to 0.4.83 (rust-lang/cargo#16379) - fix(timing): more self-contained timing/log data (rust-lang/cargo#16378) - test: update to `proc_macro::tracked::path` (rust-lang/cargo#16380) - refactor(lint): move lints to separate modules (rust-lang/cargo#16364) - fix(index): Apply feedback from Cargo team (rust-lang/cargo#16369) - fix(lints): handle lints separately at ws pkg level (rust-lang/cargo#16367) - feat(lint): new `implicit_minimum_version_req` lint (rust-lang/cargo#16321) - fix(info): default to local without explicit reg (rust-lang/cargo#16358) - Remove `[no-mentions]` handler in our triagebot config (rust-lang/cargo#16361) - Don't read the config file twice when $CARGO_HOME is a symlink (rust-lang/cargo#16325) - fix(timings): forgot to negate filter (rust-lang/cargo#16352) - fix(doctest): Include all search paths with new build layout (rust-lang/cargo#16348) - fix(layout): Remove hashes from bins in new layout (rust-lang/cargo#16351) - docs(faq): Include an entry on disk space (rust-lang/cargo#16349) - feat(timings): derive concurrency data from unit data (rust-lang/cargo#16350) - perf(layout): Use unit_id, not pkg hash, for bin/lib pkg_dirs for new layout (rust-lang/cargo#16345) - Validate target source paths before compilation with clearer errors (rust-lang/cargo#16338) - test(doc): Remove unused build script (rust-lang/cargo#16344) - refactor(timings): store UnitData in RenderContext instead (rust-lang/cargo#16346) - perf(clean): Optimize (legacy) clean with multiple -p specifiers (rust-lang/cargo#16264) - test: Adjust output for out-of-tree build-dir (rust-lang/cargo#16343)

rustbot assigned ehuss Dec 11, 2025

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 11, 2025

weihanglo mentioned this pull request Dec 11, 2025

"SSL peer certificate or SSH remote key was not OK" error with latest nightly cargo on FreeBSD #16357

Open

weihanglo reviewed Dec 11, 2025

View reviewed changes

rustbot added the A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. label Dec 11, 2025

weihanglo reviewed Dec 11, 2025

View reviewed changes

weihanglo approved these changes Dec 11, 2025

View reviewed changes

asomers force-pushed the curl-sys-0.4.83 branch from 69d0090 to 389962f Compare December 11, 2025 18:13

weihanglo enabled auto-merge December 11, 2025 18:45

weihanglo added this pull request to the merge queue Dec 11, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2025

weihanglo added this pull request to the merge queue Dec 11, 2025

Merged via the queue into rust-lang:master with commit c55b3bc Dec 11, 2025
30 checks passed

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 11, 2025

weihanglo mentioned this pull request Dec 12, 2025

Update cargo submodule rust-lang/rust#149934

Merged

rustbot added this to the 1.94.0 milestone Dec 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Downgrade curl-sys to 0.4.83 #16379

Downgrade curl-sys to 0.4.83 #16379

asomers commented Dec 11, 2025

Uh oh!

rustbot commented Dec 11, 2025

Uh oh!

weihanglo Dec 11, 2025

Uh oh!

weihanglo Dec 11, 2025

Uh oh!

weihanglo left a comment •

edited by rustbot

Loading

Uh oh!

weihanglo commented Dec 11, 2025

Uh oh!

asomers commented Dec 11, 2025

Uh oh!

weihanglo commented Dec 11, 2025

Uh oh!

rustbot commented Dec 11, 2025

Uh oh!

asomers commented Dec 11, 2025

Uh oh!

Uh oh!

Uh oh!

ehuss commented Dec 12, 2025

Uh oh!

weihanglo commented Dec 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Downgrade curl-sys to 0.4.83 #16379

Downgrade curl-sys to 0.4.83 #16379

Conversation

asomers commented Dec 11, 2025

What does this PR try to resolve?

How to test and review this PR?

Uh oh!

rustbot commented Dec 11, 2025

Uh oh!

weihanglo Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

weihanglo Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

weihanglo left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

weihanglo commented Dec 11, 2025

Uh oh!

asomers commented Dec 11, 2025

Uh oh!

weihanglo commented Dec 11, 2025

Uh oh!

rustbot commented Dec 11, 2025

Uh oh!

asomers commented Dec 11, 2025

Uh oh!

Uh oh!

Uh oh!

ehuss commented Dec 12, 2025

Uh oh!

weihanglo commented Dec 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

weihanglo left a comment •

edited by rustbot

Loading