escape_html: Avoid buffer allocation for strings with no escapable character #85
+20
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks. I will look test failure of mingw platform. It may be caused with ruby/setup-ruby#818 |
nobu
force-pushed
the
optimized_escape_html
branch
from
8834387 to
6a77d43
Compare
with no escapable character - Perform buffer allocation on first instance of escapable character. - Instead of copying characters one at a time, copy unescaped segments using `memcpy`.
ioquatix
force-pushed
the
optimized_escape_html
branch
from
6a77d43 to
469a45e
Compare
ioquatix
reviewed
Dec 9, 2025
| const char *segment_start = cstr; | ||
| char *dest = NULL; | ||
| while (cstr < end) { | ||
| const unsigned char c = *cstr++; |
Member
There was a problem hiding this comment.
I find this line confusing, since it means on line 60 we need to subtract by 1 to undo the increment. Can we move the increment to the end of the loop?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of the change I submitted in ruby/erb#87.
memcpy.Note: the cgi implementation differs from the erb implementation in that it always creates a new string (using
rb_str_dup), even for strings without any escapable characters, while the erb implementation will return the input string unchanged.