Only prepend file:// to the script's URL if it's not there already
#118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andarist
commented
Sep 23, 2025
| return; | ||
| } | ||
| url = std::string("file://") + name.get(); | ||
| std::string name_str(name.get()); |
Member
Author
There was a problem hiding this comment.
Out of 1044 sources in a recording 21 were affected by this issue:
[
"file://file:///tmp/nut/repository/90a83894-6c8d-4437-a22b-45c890569c63/tests/playwright.config.ts",
"file://file:///tmp/nut/repository/90a83894-6c8d-4437-a22b-45c890569c63/node_modules/.pnpm/@playwright+test@1.52.0/node_modules/@playwright/test/index.mjs",
"file://file:///tmp/nut/repository/90a83894-6c8d-4437-a22b-45c890569c63/node_modules/.pnpm/playwright@1.52.0/node_modules/playwright/test.mjs",
"file://file:///tmp/nut/repository/90a83894-6c8d-4437-a22b-45c890569c63/tests/todo-priorities.test.ts",
"file://file:///tmp/nut/repository/90a83894-6c8d-4437-a22b-45c890569c63/tests/fixtures/authFixture.ts",
"file://file:///tmp/nut/repository/90a83894-6c8d-4437-a22b-45c890569c63/shared-node/network.ts",
"file://file:///tmp/nut/repository/90a83894-6c8d-4437-a22b-45c890569c63/shared-node/fetch-polyfill.ts",
"file://file:///tmp/nut/repository/90a83894-6c8d-4437-a22b-45c890569c63/shared-node/node-globals-polyfill.ts",
"file://file:///tmp/nut/repository/90a83894-6c8d-4437-a22b-45c890569c63/node_modules/.pnpm/@mswjs+interceptors@0.39.6/node_modules/@mswjs/interceptors/lib/node/interceptors/fetch/index.mjs",
"file://file:///tmp/nut/repository/90a83894-6c8d-4437-a22b-45c890569c63/node_modules/.pnpm/@mswjs+interceptors@0.39.6/node_modules/@mswjs/interceptors/lib/node/chunk-WI4WZWP4.mjs",
"file://file:///tmp/nut/repository/90a83894-6c8d-4437-a22b-45c890569c63/node_modules/.pnpm/@mswjs+interceptors@0.39.6/node_modules/@mswjs/interceptors/lib/node/chunk-TX5GBTFY.mjs",
"file://file:///tmp/nut/repository/90a83894-6c8d-4437-a22b-45c890569c63/node_modules/.pnpm/@mswjs+interceptors@0.39.6/node_modules/@mswjs/interceptors/lib/node/chunk-6YM4PLBI.mjs",
"file://file:///tmp/nut/repository/90a83894-6c8d-4437-a22b-45c890569c63/node_modules/.pnpm/@mswjs+interceptors@0.39.6/node_modules/@mswjs/interceptors/lib/node/chunk-A7Q4RTDJ.mjs",
"file://file:///tmp/nut/repository/90a83894-6c8d-4437-a22b-45c890569c63/node_modules/.pnpm/outvariant@1.4.3/node_modules/outvariant/lib/index.mjs",
"file://file:///tmp/nut/repository/90a83894-6c8d-4437-a22b-45c890569c63/node_modules/.pnpm/@open-draft+deferred-promise@2.2.0/node_modules/@open-draft/deferred-promise/build/index.mjs",
"file://file:///tmp/nut/repository/90a83894-6c8d-4437-a22b-45c890569c63/node_modules/.pnpm/@open-draft+until@2.1.0/node_modules/@open-draft/until/lib/index.mjs",
"file://file:///tmp/nut/repository/90a83894-6c8d-4437-a22b-45c890569c63/node_modules/.pnpm/@mswjs+interceptors@0.39.6/node_modules/@mswjs/interceptors/lib/node/chunk-IHJSPMYM.mjs",
"file://file:///tmp/nut/repository/90a83894-6c8d-4437-a22b-45c890569c63/node_modules/.pnpm/@open-draft+logger@0.3.0/node_modules/@open-draft/logger/lib/index.mjs",
"file://file:///tmp/nut/repository/90a83894-6c8d-4437-a22b-45c890569c63/node_modules/.pnpm/is-node-process@1.2.0/node_modules/is-node-process/lib/index.mjs",
"file://file:///tmp/nut/repository/90a83894-6c8d-4437-a22b-45c890569c63/node_modules/.pnpm/strict-event-emitter@0.5.1/node_modules/strict-event-emitter/lib/index.mjs",
"file://file:///tmp/nut/repository/90a83894-6c8d-4437-a22b-45c890569c63/node_modules/.pnpm/@mswjs+interceptors@0.39.6/node_modules/@mswjs/interceptors/lib/node/chunk-3GJB4JDF.mjs"
]I'm not 100% sure what's the exact reason but my educated guess is those were loaded through a custom ESM loader and apparently, file:// was already added by that in the process.
Domiii
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.