Skip to content

Conversation

@chengluyu
Copy link
Collaborator

@chengluyu chengluyu commented Nov 19, 2025

close: #100

@vercel
Copy link

vercel bot commented Nov 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
recho-notebook Ready Ready Preview Comment Nov 26, 2025 1:24am

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new interactive button control (recho.button) to the Recho Notebook system, allowing users to create clickable buttons that execute callback functions.

Key changes:

  • Implements ButtonRegistry to manage button callbacks with duplicate detection
  • Creates editor widgets that render buttons inline with code
  • Adds comprehensive documentation with usage examples

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
runtime/index.js Integrates ButtonRegistry into the runtime, initializing it per-instance and managing execution cycles
runtime/controls/button.js Implements ButtonRegistry class for callback management and the button() function with two-argument and three-argument signatures
runtime/controls/index.js Exports the button control function
editor/controls/button.js Implements ButtonWidget and ButtonPlugin for rendering interactive buttons in the CodeMirror editor
editor/controls/index.js Integrates button control into the editor controls array
app/docs/nav.config.js Adds navigation entry for button API documentation
app/docs/api-reference.recho.js Adds button to the API reference list
app/docs/api-button.recho.js Provides detailed documentation and usage examples for recho.button

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

chengluyu and others added 2 commits November 19, 2025 12:45
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Collaborator

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@pearmini pearmini merged commit fb9d0f5 into main Nov 26, 2025
3 checks passed
@pearmini pearmini deleted the feat/buttons branch November 26, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add inputs (button, toggle, radio, number)

3 participants