-
Notifications
You must be signed in to change notification settings - Fork 4
Add recho.button
#198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recho.button
#198
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new interactive button control (recho.button) to the Recho Notebook system, allowing users to create clickable buttons that execute callback functions.
Key changes:
- Implements
ButtonRegistryto manage button callbacks with duplicate detection - Creates editor widgets that render buttons inline with code
- Adds comprehensive documentation with usage examples
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| runtime/index.js | Integrates ButtonRegistry into the runtime, initializing it per-instance and managing execution cycles |
| runtime/controls/button.js | Implements ButtonRegistry class for callback management and the button() function with two-argument and three-argument signatures |
| runtime/controls/index.js | Exports the button control function |
| editor/controls/button.js | Implements ButtonWidget and ButtonPlugin for rendering interactive buttons in the CodeMirror editor |
| editor/controls/index.js | Integrates button control into the editor controls array |
| app/docs/nav.config.js | Adds navigation entry for button API documentation |
| app/docs/api-reference.recho.js | Adds button to the API reference list |
| app/docs/api-button.recho.js | Provides detailed documentation and usage examples for recho.button |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
pearmini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
close: #100